From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 29/29] xentrace: undeadify invalid option
	argument handling
Date: Wed, 30 Oct 2013 12:47:26 +0000
Message-ID: <5270FFDE.2000201@eu.citrix.com>
References: <1383119525-26033-1-git-send-email-mattjd@gmail.com>
	<1383119525-26033-30-git-send-email-mattjd@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1383119525-26033-30-git-send-email-mattjd@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 30/10/13 07:52, Matthew Daley wrote:
> Apparently it's always been like this.
>
> Coverity-ID: 1056153
> Signed-off-by: Matthew Daley <mattjd@gmail.com>

Weird!

Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>

> ---
>   tools/xentrace/xentrace.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
> index 504763d..8a38e32 100644
> --- a/tools/xentrace/xentrace.c
> +++ b/tools/xentrace/xentrace.c
> @@ -858,10 +858,11 @@ long sargtol(const char *restrict arg, int base)
>   
>   
>       return val;
> +
>   invalid:
> -    return 0;
>       fprintf(stderr, "Invalid option argument: %s\n\n", arg);
>       usage();
> +    return 0; /* not actually reached */
>   }
>   
>   /* convert the argument string pointed to by arg to a long int representation */