From: Julien Grall <julien.grall@linaro.org>
To: Jon Fraser <jfraser@broadcom.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, ian.campbell@citrix.com
Subject: Re: [PATCH V2] xen/arm: UART addresses are not always aligned to a page.
Date: Wed, 30 Oct 2013 16:09:17 -0700 [thread overview]
Message-ID: <5271919D.9010709@linaro.org> (raw)
In-Reply-To: <1383167881-29571-1-git-send-email-jfraser@broadcom.com>
On 10/30/2013 02:18 PM, Jon Fraser wrote:
> When calculating the virtual address of the UART,
> add the page offset of the UART to the mapped address.
>
> Create define EARLY_UART_VIRTUAL_ADDRESS and use instead
> of FIXMAP_ADDR(FIXMAP_CONSOLE)
>
> Signed-off-by: Jon Fraser <jfraser@broadcom.com>
> ---
[...]
> diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h
> index 5f7c529..759d59a 100644
> --- a/xen/include/asm-arm/early_printk.h
> +++ b/xen/include/asm-arm/early_printk.h
> @@ -12,6 +12,14 @@
>
> #include <xen/config.h>
>
> +#ifdef __ASSEMBLY__
> +
> +/* need to add the uart address offset in page to the fixmap address */
> +#define EARLY_UART_VIRTUAL_ADDRESS \
> + (FIXMAP_ADDR(FIXMAP_CONSOLE) +(EARLY_UART_BASE_ADDRESS & ~PAGE_MASK))
> +
Aside Andrew's comment, you should only define
EARLY_UART_VIRTUAL_ADDRESS when EARLY_PRINTK is enabled.
--
Julien Grall
prev parent reply other threads:[~2013-10-30 23:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 21:18 [PATCH V2] xen/arm: UART addresses are not always aligned to a page Jon Fraser
2013-10-30 21:25 ` Andrew Cooper
2013-10-30 22:53 ` Jon Fraser
2013-10-31 16:27 ` Ian Campbell
2013-10-31 19:37 ` [PATCH V3] " Jon Fraser
2013-10-31 19:52 ` Ian Campbell
2013-10-31 20:11 ` Jon Fraser
2013-10-31 20:47 ` Ian Campbell
2013-11-01 13:24 ` Ian Campbell
2013-10-30 23:09 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271919D.9010709@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=jfraser@broadcom.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).