From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] Fix NULL pointer dereference in
 ARINC653 free_vdata.
Date: Fri, 1 Nov 2013 13:56:48 +0000
Message-ID: <5273B320.6070201@citrix.com>
References: <1383252473-3067-1-git-send-email-nate.studer@dornerworks.com>
	<1383252473-3067-3-git-send-email-nate.studer@dornerworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1383252473-3067-3-git-send-email-nate.studer@dornerworks.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Nathan Studer <nate.studer@dornerworks.com>
Cc: george.dunlap@eu.citrix.com, smartin@milliways.cl, robert.vanvossen@dornerworks.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 31/10/13 20:47, Nathan Studer wrote:
> From: Nathan Studer <nate.studer@dornerworks.com>
>
> The ARINC653 scheduler alloc_vdata function does not add the
> idle cpu to its internal vcpu_list, but when the free_vdata
> function is called, the scheduler attempted to remove the vcpu
> from its internal vcpu_list, regardless of whether or not
> the vcpu was the idle vcpu.  Since the idle vcpu's list field
> was never initialized, a NULL pointer was passed to list_del.
>
> When using cpupools, this resulted in a crash when moving a cpu
> from an arinc653 scheduler pool.
>
> Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>

This again looks sane, but can't it logically be merged with the
previous patch?  Both of the patches are "dont break on
{alloc,free}_vdata when using cpupools"

I guess this is a matter of taste.

~Andrew

> ---
>  xen/common/sched_arinc653.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/sched_arinc653.c b/xen/common/sched_arinc653.c
> index a1d9443..8a5bd9c 100644
> --- a/xen/common/sched_arinc653.c
> +++ b/xen/common/sched_arinc653.c
> @@ -418,7 +418,9 @@ a653sched_free_vdata(const struct scheduler *ops, void *priv)
>      if (av == NULL)
>          return;
>  
> -    list_del(&av->list);
> +    if ( !is_idle_vcpu(av->vc) )
> +        list_del(&av->list);
> +
>      xfree(av);
>      update_schedule_vcpus(ops);
>  }