Re: [PATCH 2/2] Fix NULL pointer dereference in ARINC653 free_vdata.

[George Dunlap <george.dunlap@eu.citrix.com>]

On 01/11/13 13:56, Andrew Cooper wrote:
> On 31/10/13 20:47, Nathan Studer wrote:
>> From: Nathan Studer <nate.studer@dornerworks.com>
>>
>> The ARINC653 scheduler alloc_vdata function does not add the
>> idle cpu to its internal vcpu_list, but when the free_vdata
>> function is called, the scheduler attempted to remove the vcpu
>> from its internal vcpu_list, regardless of whether or not
>> the vcpu was the idle vcpu.  Since the idle vcpu's list field
>> was never initialized, a NULL pointer was passed to list_del.
>>
>> When using cpupools, this resulted in a crash when moving a cpu
>> from an arinc653 scheduler pool.
>>
>> Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>
> This again looks sane, but can't it logically be merged with the
> previous patch?  Both of the patches are "dont break on
> {alloc,free}_vdata when using cpupools"
>
> I guess this is a matter of taste.

I don't think it's worth asking for a whole re-spin just to merge two 
relatively short commits that *could* be merged but also work separately.

Both these patches can have my Ack, BTW (although I don't think they 
need it): I just wanted to be a good citizen and do a bit of review. :-)

  -George