From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH RFC v13 05/20] pvh: Disable unneeded
	features of HVM containers
Date: Mon, 4 Nov 2013 12:31:37 +0000
Message-ID: <527793A9.8030301@eu.citrix.com>
References: <1379955000-11050-1-git-send-email-george.dunlap@eu.citrix.com>
	<1379955000-11050-6-git-send-email-george.dunlap@eu.citrix.com>
	<52446D4502000078000F7098@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1VdJJm-0002xF-2w
	for xen-devel@lists.xenproject.org; Mon, 04 Nov 2013 12:31:42 +0000
In-Reply-To: <52446D4502000078000F7098@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 26/09/13 16:22, Jan Beulich wrote:
>>>> On 23.09.13 at 18:49, George Dunlap <george.dunlap@eu.citrix.com> wrote:
>> @@ -578,6 +592,9 @@ int hvm_domain_initialise(struct domain *d)
>>   
>>   void hvm_domain_relinquish_resources(struct domain *d)
>>   {
>> +    if ( is_pvh_domain(d) )
>> +        return;
>> +
> Iirc in an earlier patch you're allocating ->arch.hvm_domain.params.
> Which is supposed to be freed here, and hence would now be
> leaked for PVH domains.
>
>> @@ -1114,6 +1135,14 @@ int hvm_vcpu_initialise(struct vcpu *v)
>>   
>>       v->arch.hvm_vcpu.inject_trap.vector = -1;
>>   
>> +    if ( is_pvh_vcpu(v) )
>> +    {
>> +        v->arch.hvm_vcpu.hcall_64bit = 1;    /* PVH 32bitfixme. */
>> +        /* This for hvm_long_mode_enabled(v). */
>> +        v->arch.hvm_vcpu.guest_efer = EFER_SCE | EFER_LMA | EFER_LME;
> Please fix the comment (perhaps just missing an "is").

Gah...  Sorry Jan, I thought I had already gone through and addressed a 
number of these things you pointed out, but apparently I hadn't.  I'll 
go through the series again...

  -George