From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH RFC v13 19/20] PVH xen tools: libxc changes to build a PVH guest. Date: Mon, 4 Nov 2013 14:18:56 +0100 Message-ID: <52779EC0.2040609@citrix.com> References: <1379955000-11050-1-git-send-email-george.dunlap@eu.citrix.com> <1379955000-11050-20-git-send-email-george.dunlap@eu.citrix.com> <526165C3.9080400@citrix.com> <52778B64.70400@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <52778B64.70400@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , xen-devel@lists.xen.org Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 04/11/13 12:56, George Dunlap wrote: > On 18/10/13 17:45, Roger Pau Monn=E9 wrote: >> This patch is incomplete, PVH guests with 4GB of RAM or more will fail >> to boot due to libxc temporary mapping the grant table to gfn 0xFFFFE, >> which is an invalid gfn on HVM guests, but not on PVH guests. When >> libxc removes the mapping of 0xFFFFE it will leave an invalid mfn in >> the p2m table, that will make the guest crash when trying to access >> that gfn. >> >> The easiest way I've found to solve this is to temporary map the grant >> table to the maximum gfn + 1. This fixes the PVH issue, and also seems >> to work fine with HVM guests, here is the diff which should probably be >> integrated into this patch: > = > Thanks Roger. I assume it's OK to add your sign-off to this patch? Yes, you can merge it with the current patch. Roger.