From: Bob Liu <bob.liu@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Bob Liu <lliubbo@gmail.com>,
keir@xen.org, ian.campbell@citrix.com
Subject: Re: [RFC PATCH 00/11] tmem: some basic cleanup
Date: Tue, 05 Nov 2013 10:04:43 +0800 [thread overview]
Message-ID: <5278523B.3060806@oracle.com> (raw)
In-Reply-To: <5277D1B602000078000FF2B6@nat28.tlf.novell.com>
On 11/04/2013 11:56 PM, Jan Beulich wrote:
>>>> On 04.11.13 at 13:40, Bob Liu <lliubbo@gmail.com> wrote:
>> There are too many typedefs and referenced once functions in tmem, perhaps the
>> reason was tmem was designed can be ported to other hypersivor easily.
>> But when I try to read tmem source code, some of them are not very
>> straightforward. This patchset try to clean up them. It's only my thoughts so I
>> tag this patchset with RFC.
>
> If I was the maintainer, or as to make a recommendation, I wouldn't
> accept these changes - they were done for a purpose after all. If
> anything a re-work from grounds up would seem the only reasonable
> option.
>
Well, I'd like re-work tmem from ground also.
But currently it's too difficult for me to re-work it since I don't have
enough knowledge. It's hard for me to understand tmem quickly because of
its order of complexity and I'm not fit to its coding style.
Clean up patches will also be the first step even reworking it from
grounds unless we can start with a new better/simpler tmem.c
implementation and replace current one directly.
--
Regards,
-Bob
next prev parent reply other threads:[~2013-11-05 2:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 12:40 [RFC PATCH 00/11] tmem: some basic cleanup Bob Liu
2013-11-04 12:40 ` [PATCH 01/11] tmem: cleanup: drop COMPARE_COPY_PAGE_SSE2 Bob Liu
2013-11-04 12:40 ` [PATCH 02/11] tmem: cleanup: drop typedef pfp_t Bob Liu
2013-11-04 12:40 ` [PATCH 03/11] tmem: cleanup: drop typedef tmem_cli_mfn_t Bob Liu
2013-11-04 12:40 ` [PATCH 04/11] tmem: cleanup: rename 'tmh_' with 'tmem_' Bob Liu
2013-11-04 12:40 ` [PATCH 05/11] tmem: cleanup: drop most of the typedefs Bob Liu
2013-11-04 12:40 ` [PATCH 06/11] tmem: cleanup: drop function tmem_alloc/free_infra Bob Liu
2013-11-04 12:40 ` [PATCH 07/11] tmem: cleanup: drop typedef tmem_client_t Bob Liu
2013-11-04 12:40 ` [PATCH 08/11] tmem: cleanup: drop useless wrap functions Bob Liu
2013-11-04 12:40 ` [PATCH 09/11] tmem: cleanup: drop unused function 'domain_fully_allocated' Bob Liu
2013-11-04 12:40 ` [PATCH 10/11] tmem: cleanup: drop useless '_subpage' wrap functions Bob Liu
2013-11-04 12:40 ` [PATCH 11/11] tmem: cleanup: drop useless functions Bob Liu
2013-11-04 15:56 ` [RFC PATCH 00/11] tmem: some basic cleanup Jan Beulich
2013-11-04 16:48 ` Konrad Rzeszutek Wilk
2013-11-05 2:04 ` Bob Liu [this message]
2013-11-05 9:03 ` Jan Beulich
2013-11-05 14:46 ` Konrad Rzeszutek Wilk
2013-11-05 14:57 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5278523B.3060806@oracle.com \
--to=bob.liu@oracle.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=lliubbo@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).