From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Liu Subject: Re: [RFC PATCH 00/11] tmem: some basic cleanup Date: Tue, 05 Nov 2013 10:04:43 +0800 Message-ID: <5278523B.3060806@oracle.com> References: <1383568854-30521-1-git-send-email-bob.liu@oracle.com> <5277D1B602000078000FF2B6@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VdW0l-0007v2-9a for xen-devel@lists.xenproject.org; Tue, 05 Nov 2013 02:04:55 +0000 In-Reply-To: <5277D1B602000078000FF2B6@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Bob Liu , keir@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 11/04/2013 11:56 PM, Jan Beulich wrote: >>>> On 04.11.13 at 13:40, Bob Liu wrote: >> There are too many typedefs and referenced once functions in tmem, perhaps the >> reason was tmem was designed can be ported to other hypersivor easily. >> But when I try to read tmem source code, some of them are not very >> straightforward. This patchset try to clean up them. It's only my thoughts so I >> tag this patchset with RFC. > > If I was the maintainer, or as to make a recommendation, I wouldn't > accept these changes - they were done for a purpose after all. If > anything a re-work from grounds up would seem the only reasonable > option. > Well, I'd like re-work tmem from ground also. But currently it's too difficult for me to re-work it since I don't have enough knowledge. It's hard for me to understand tmem quickly because of its order of complexity and I'm not fit to its coding style. Clean up patches will also be the first step even reworking it from grounds unless we can start with a new better/simpler tmem.c implementation and replace current one directly. -- Regards, -Bob