From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH RESEND 05/12] xen: numa-sched: make space
 for per-vcpu node-affinity
Date: Tue, 5 Nov 2013 15:24:31 +0000
Message-ID: <52790DAF.8020703@eu.citrix.com>
References: <20131105142844.30446.78671.stgit@Solace>
	<20131105143500.30446.9976.stgit@Solace>
	<5279143702000078000FFB15@nat28.tlf.novell.com>
	<527908B2.5090208@eu.citrix.com>
	<5279189502000078000FFB7F@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1VdiUg-0003Kq-Rb
	for xen-devel@lists.xenproject.org; Tue, 05 Nov 2013 15:24:39 +0000
In-Reply-To: <5279189502000078000FFB7F@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: MarcusGranado <Marcus.Granado@eu.citrix.com>, Justin Weaver <jtweaver@hawaii.edu>, Ian Campbell <Ian.Campbell@citrix.com>, Li Yechen <lccycc123@gmail.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Matt Wilson <msw@amazon.com>, xen-devel <xen-devel@lists.xenproject.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, KeirFraser <keir@xen.org>, Elena Ufimtseva <ufimtseva@gmail.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On 11/05/2013 03:11 PM, Jan Beulich wrote:
>>>> On 05.11.13 at 16:03, George Dunlap <george.dunlap@eu.citrix.com> wrote:
>> On 11/05/2013 02:52 PM, Jan Beulich wrote:
>>>>>> On 05.11.13 at 15:35, Dario Faggioli <dario.faggioli@citrix.com> wrote:
>>>> @@ -197,6 +199,13 @@ struct vcpu
>>>>        /* Used to restore affinity across S3. */
>>>>        cpumask_var_t    cpu_affinity_saved;
>>>>
>>>> +    /*
>>>> +     * Bitmask of CPUs on which this VCPU prefers to run. For both this
>>>> +     * and auto_node_affinity access is serialized against
>>>> +     * v->domain->node_affinity_lock.
>>>> +     */
>>>> +    cpumask_var_t    node_affinity;
>>>
>>> This all looks quite sensible, except for the naming here: We
>>> already have a node_affinity field in struct domain, having a
>>> meaning that one can expect with this name. So you break
>>> both consistency and the rule of least surprise here. How
>>> about just "preferred_cpus"?
>>
>> Actually, would it make more sense to remove node_affinity from the
>> domain struct, and have the tools manually set the node_affinity for the
>> various vcpus if the user attempts to set the "domain numa affinity"?
>
> Quite likely, yes. But that doesn't mean that the name can be kept
> as is.

Right, I see what you're saying -- in the domain struct, node_affinity 
is a mask of nodes, but here it's being used as a mask of cpus.  Yes, 
that needs to change.

  -George