From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v14 03/17] pvh prep: code motion Date: Thu, 7 Nov 2013 10:48:46 +0000 Message-ID: <527B700E.2060604@eu.citrix.com> References: <1383567306-6636-1-git-send-email-george.dunlap@eu.citrix.com> <1383567306-6636-4-git-send-email-george.dunlap@eu.citrix.com> <5277D5E802000078000FF2EC@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VeN9M-0003tq-GX for xen-devel@lists.xenproject.org; Thu, 07 Nov 2013 10:49:20 +0000 In-Reply-To: <5277D5E802000078000FF2EC@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 04/11/13 16:14, Jan Beulich wrote: >>>> On 04.11.13 at 13:14, George Dunlap wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -522,27 +522,27 @@ int hvm_domain_initialise(struct domain *d) >> spin_lock_init(&d->arch.hvm_domain.irq_lock); >> spin_lock_init(&d->arch.hvm_domain.uc_lock); >> >> - INIT_LIST_HEAD(&d->arch.hvm_domain.msixtbl_list); >> - spin_lock_init(&d->arch.hvm_domain.msixtbl_list_lock); > While I can see the need for moving stuff so that it gets done > earlier - why do these two lines need to be moved _down_? > Even if PVH wasn't using the MSI-X support code HVM needs, > I can't see them doing any harm. Right -- sorry, when shuffling things around a lot (which I did while trying to figure out how I had broken HVM guests in v13) you miss this sort of thing. I'll un-do this hunk. -George