From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH RFC v13 13/20] pvh: Set up more PV stuff in
	set_info_guest
Date: Thu, 7 Nov 2013 15:57:28 +0000
Message-ID: <527BB868.1060007@eu.citrix.com>
References: <1379955000-11050-1-git-send-email-george.dunlap@eu.citrix.com>
	<1379955000-11050-14-git-send-email-george.dunlap@eu.citrix.com>
	<5244722902000078000F7110@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1VeRxh-0003ed-Hr
	for xen-devel@lists.xenproject.org; Thu, 07 Nov 2013 15:57:37 +0000
In-Reply-To: <5244722902000078000F7110@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 26/09/13 16:43, Jan Beulich wrote:
>> @@ -736,8 +748,24 @@ int arch_set_info_guest(
>>   
>>       if ( has_hvm_container_vcpu(v) )
>>       {
>> -        hvm_set_info_guest(v);
>> -        goto out;
>> +        hvm_set_info_guest(v, compat ? 0 : c.nat->gs_base_kernel);
> I had pointed this out to Mukesh already: If you want to imply kernel
> mode here, the checks above should verify that the kernel mode flag
> is set in flags.

It looks like for some reason TF_kernel_mode is set unconditionally for 
HVM guests (though the /*???*/ would seem to indicate that someone at 
some point didn't understand why):

     if ( (flags & VGCF_in_kernel) || has_hvm_container_vcpu(v)/*???*/ )
         v->arch.flags |= TF_kernel_mode;

  I'll add a comment pointing this out.

  -George