From: George Dunlap <george.dunlap@eu.citrix.com>
To: Don Slutz <dslutz@verizon.com>,
xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v2 00/12] xenctx: Many changes.
Date: Fri, 8 Nov 2013 11:29:32 +0000 [thread overview]
Message-ID: <527CCB1C.4070800@eu.citrix.com> (raw)
In-Reply-To: <1383768500-4245-1-git-send-email-dslutz@terremark.com>
On 06/11/13 20:08, Don Slutz wrote:
> From: Don Slutz <dslutz@verizon.com>
>
> Change from v1 to v2:
> title was: xenctx: Add an option to output more registers.
> Processed review comments.
> Jan Beulich:
> Split 1 change into 12.
> Switch to enum for is_kernel_text(), renamed to is_kernel_addr().
> Renamed vars like memAddr to mem_addr.
> Ian Campbell:
> More on is_kernel_text().
I don't think this series really needs my Ack -- xenctx is actually in
the wrong place, AFAICT, as it doesn't have anything really to do with
xentrace. Its functionality is more similar to xen-hvmctx, which ATM
lives in tools/misc.
At some point it might make sense to reorg stuff a bit...
-George
next prev parent reply other threads:[~2013-11-08 11:29 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:08 [PATCH v2 00/12] xenctx: Many changes Don Slutz
2013-11-06 20:08 ` [PATCH v2 01/12] xenctx: Clean up stack trace when hypercall_page not in symbol table Don Slutz
2013-11-07 8:07 ` Jan Beulich
2013-11-07 8:22 ` Ian Campbell
2013-11-07 8:47 ` Jan Beulich
2013-11-07 12:36 ` Ian Campbell
2013-11-07 13:28 ` Don Slutz
2013-11-07 12:38 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 02/12] xenctx: Add -2 (--two-pages) option to switch stack size to 8KiB Don Slutz
2013-11-07 8:04 ` Jan Beulich
2013-11-07 12:40 ` Ian Campbell
2013-11-07 15:24 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 03/12] xenctx: Output ascii version of stack also Don Slutz
2013-11-07 8:09 ` Jan Beulich
2013-11-07 12:43 ` Ian Campbell
2013-11-07 13:17 ` Jan Beulich
2013-11-07 13:21 ` Jan Beulich
2013-11-08 0:12 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 04/12] xenctx: Add stack address to dump, switch to 16 bytes per line Don Slutz
2013-11-07 8:12 ` Jan Beulich
2013-11-07 12:46 ` Ian Campbell
2013-11-08 0:13 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 05/12] xenctx: Change print_symbol to do the space before Don Slutz
2013-11-07 8:13 ` Jan Beulich
2013-11-07 12:47 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 06/12] xenctx: More info on failed to map page Don Slutz
2013-11-07 12:48 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 07/12] xenctx: Add stack addr to call trace Don Slutz
2013-11-07 12:50 ` Ian Campbell
2013-11-07 14:34 ` Don Slutz
2013-11-07 14:44 ` Ian Campbell
2013-11-07 15:06 ` Don Slutz
2013-11-07 16:03 ` Ian Campbell
2013-11-07 18:13 ` Don Slutz
2013-11-08 10:15 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 08/12] xenctx: Add -d <daddr> option to dump memory at daddr as a stack Don Slutz
2013-11-07 8:22 ` Jan Beulich
2013-11-08 0:21 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 09/12] xenctx: Add -m <maddr> option to dump memory at maddr Don Slutz
2013-11-07 8:25 ` Jan Beulich
2013-11-08 0:24 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 10/12] xenctx: change is_kernel_text() into is_kernel_addr() Don Slutz
2013-11-07 8:35 ` Jan Beulich
2013-11-08 0:51 ` Don Slutz
2013-11-08 8:40 ` Jan Beulich
2013-11-08 9:50 ` Ian Campbell
2013-11-08 13:50 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 11/12] xenctx: Dump registers via hvm info if available Don Slutz
2013-11-06 20:35 ` Andrew Cooper
2013-11-07 18:56 ` Don Slutz
2013-11-08 10:13 ` Ian Campbell
2013-11-08 10:29 ` Andrew Cooper
2013-11-08 10:32 ` Ian Campbell
2013-11-07 8:38 ` Jan Beulich
2013-11-07 21:19 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 12/12] xenctx: Add optional fCPU Don Slutz
2013-11-07 8:40 ` Jan Beulich
2013-11-07 12:53 ` Ian Campbell
2013-11-07 21:24 ` Don Slutz
2013-11-08 11:29 ` George Dunlap [this message]
2013-11-08 12:54 ` [PATCH v2 00/12] xenctx: Many changes Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CCB1C.4070800@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=dslutz@verizon.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).