From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Matthew Daley <mattjd@gmail.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 1/6] nestedsvm: remove pointless BUG_ON
Date: Fri, 08 Nov 2013 09:28:12 -0500 [thread overview]
Message-ID: <527CF4FC.2000904@oracle.com> (raw)
In-Reply-To: <1383871513-11316-2-git-send-email-mattjd@gmail.com>
On 11/07/2013 07:45 PM, Matthew Daley wrote:
> It's already handled just above.
>
> Signed-off-by: Matthew Daley <mattjd@gmail.com>
> ---
> xen/arch/x86/hvm/svm/nestedsvm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
> index e32c872..705b653 100644
> --- a/xen/arch/x86/hvm/svm/nestedsvm.c
> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c
> @@ -847,7 +847,6 @@ nsvm_vmcb_guest_intercepts_msr(unsigned long *msr_bitmap,
> /* MSR not in the permission map: Let the guest handle it. */
> return NESTEDHVM_VMEXIT_INJECT;
>
> - BUG_ON(msr_bit == NULL);
> msr &= 0x1fff;
>
> if (write)
Acked-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2013-11-08 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
2013-11-08 0:45 ` [PATCH 1/6] nestedsvm: remove pointless BUG_ON Matthew Daley
2013-11-08 14:28 ` Boris Ostrovsky [this message]
2013-11-08 0:45 ` [PATCH 2/6] xen/arm: remove pointless if subcondition Matthew Daley
2013-11-08 0:45 ` [PATCH 3/6] xen/video: " Matthew Daley
2013-11-08 0:45 ` [PATCH 4/6] libxc: remove pointless null pointer check Matthew Daley
2013-11-08 0:45 ` [PATCH 5/6] xl: " Matthew Daley
2013-11-08 0:45 ` [PATCH 6/6] mini-os: remove repeated statement in netfront_input Matthew Daley
2013-11-08 0:56 ` Samuel Thibault
2013-11-11 16:25 ` trivial: remove various pointless things Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CF4FC.2000904@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=mattjd@gmail.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).