From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 1/6] nestedsvm: remove pointless BUG_ON Date: Fri, 08 Nov 2013 09:28:12 -0500 Message-ID: <527CF4FC.2000904@oracle.com> References: <1383871513-11316-1-git-send-email-mattjd@gmail.com> <1383871513-11316-2-git-send-email-mattjd@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383871513-11316-2-git-send-email-mattjd@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matthew Daley Cc: xen-devel@lists.xenproject.org, Keir Fraser , Jan Beulich , Suravee Suthikulpanit , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/07/2013 07:45 PM, Matthew Daley wrote: > It's already handled just above. > > Signed-off-by: Matthew Daley > --- > xen/arch/x86/hvm/svm/nestedsvm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c > index e32c872..705b653 100644 > --- a/xen/arch/x86/hvm/svm/nestedsvm.c > +++ b/xen/arch/x86/hvm/svm/nestedsvm.c > @@ -847,7 +847,6 @@ nsvm_vmcb_guest_intercepts_msr(unsigned long *msr_bitmap, > /* MSR not in the permission map: Let the guest handle it. */ > return NESTEDHVM_VMEXIT_INJECT; > > - BUG_ON(msr_bit == NULL); > msr &= 0x1fff; > > if (write) Acked-by: Boris Ostrovsky