From: David Vrabel <david.vrabel@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v2 1/5] x86/hpet: Pre cleanup
Date: Mon, 11 Nov 2013 10:49:06 +0000 [thread overview]
Message-ID: <5280B622.9040303@citrix.com> (raw)
In-Reply-To: <527CBED9.7060706@citrix.com>
On 08/11/13 10:37, Andrew Cooper wrote:
>
> So what would you suggest? Here, all the __$foo() are designed to end
> up similar to large swathes of other Xen code, implying that the
> appropriate spinlock should be held by the caller.
>
> I am not too fussed which convention we use, so long as it is used
> consistently.
I've sometimes used a _locked suffix for this.
David
next prev parent reply other threads:[~2013-11-11 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 15:28 [RFC v2 0/5] HPET fix interrupt logic Andrew Cooper
2013-11-07 15:28 ` [PATCH v2 1/5] x86/hpet: Pre cleanup Andrew Cooper
2013-11-08 9:49 ` Jan Beulich
2013-11-08 10:37 ` Andrew Cooper
2013-11-08 11:40 ` Jan Beulich
2013-11-08 16:39 ` Tim Deegan
2013-11-11 9:05 ` Jan Beulich
2013-11-11 10:49 ` David Vrabel [this message]
2013-11-07 15:28 ` [PATCH v2 2/5] x86/hpet: Use singe apic vector rather than irq_descs for HPET interrupts Andrew Cooper
2013-11-08 1:08 ` Tim Deegan
2013-11-08 11:05 ` Andrew Cooper
2013-11-07 15:28 ` [PATCH v2 3/5] x86/hpet: Post cleanup Andrew Cooper
2013-11-07 15:28 ` [PATCH v2 4/5] x86/hpet: Debug and verbose hpet logging Andrew Cooper
2013-11-07 15:28 ` [PATCH v2 5/5] x86/hpet: debug keyhandlers Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280B622.9040303@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).