From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v2 1/5] x86/hpet: Pre cleanup Date: Mon, 11 Nov 2013 10:49:06 +0000 Message-ID: <5280B622.9040303@citrix.com> References: <1383838105-9775-1-git-send-email-andrew.cooper3@citrix.com> <1383838105-9775-2-git-send-email-andrew.cooper3@citrix.com> <527CC1A602000078001011B7@nat28.tlf.novell.com> <527CBED9.7060706@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vfp3O-0003tg-Lp for xen-devel@lists.xenproject.org; Mon, 11 Nov 2013 10:49:10 +0000 In-Reply-To: <527CBED9.7060706@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: xen-devel , Keir Fraser , Jan Beulich , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 08/11/13 10:37, Andrew Cooper wrote: > > So what would you suggest? Here, all the __$foo() are designed to end > up similar to large swathes of other Xen code, implying that the > appropriate spinlock should be held by the caller. > > I am not too fussed which convention we use, so long as it is used > consistently. I've sometimes used a _locked suffix for this. David