From: David Vrabel <david.vrabel@citrix.com>
To: Matt Wilson <msw@linux.com>
Cc: Keir Fraser <keir@xen.org>, Matt Wilson <msw@amazon.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Anthony Liguori <aliguori@amazon.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] gnttab: lock the left grant table earlier in __gnttab_unmap_common()
Date: Mon, 11 Nov 2013 10:53:23 +0000 [thread overview]
Message-ID: <5280B723.5060904@citrix.com> (raw)
In-Reply-To: <1384135642-26301-1-git-send-email-msw@linux.com>
On 11/11/13 02:07, Matt Wilson wrote:
> From: Matt Wilson <msw@amazon.com>
>
> Luckily today maptrack_limit never shrinks. But if at some point in
> the future this were to change, checking maptrack_limit without
> holding the grant table spinlock would no longer be safe.
I don't think we should extend region the grant table lock protects if
it's not needed since we know this lock is heavily contended.
Also, doesn't the 'l' and 'r' prefixes mean 'local' and 'remote' not
'left' and 'right'?
David
next prev parent reply other threads:[~2013-11-11 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 2:07 [PATCH] gnttab: lock the left grant table earlier in __gnttab_unmap_common() Matt Wilson
2013-11-11 2:14 ` Anthony Liguori
2013-11-11 9:58 ` Jan Beulich
2013-11-11 14:52 ` Anthony Liguori
2013-11-11 16:23 ` Jan Beulich
2013-11-11 16:45 ` Anthony Liguori
2013-11-11 9:53 ` Andrew Cooper
2013-11-11 9:53 ` Jan Beulich
2013-11-11 10:53 ` David Vrabel [this message]
2013-11-11 14:48 ` Anthony Liguori
2013-11-11 16:29 ` David Vrabel
2013-11-11 17:21 ` Matt Wilson
2013-11-11 19:56 ` [PATCH v2] gnttab: lock the local " Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280B723.5060904@citrix.com \
--to=david.vrabel@citrix.com \
--cc=aliguori@amazon.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=msw@amazon.com \
--cc=msw@linux.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).