From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jon Fraser <jfraser@broadcom.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: Initial Broadcom A15 platform support
Date: Tue, 12 Nov 2013 12:52:27 +0000 [thread overview]
Message-ID: <5282248B.2080707@linaro.org> (raw)
In-Reply-To: <1384250223.1883.36.camel@kazak.uk.xensource.com>
On 11/12/2013 09:57 AM, Ian Campbell wrote:
> On Mon, 2013-11-11 at 20:37 +0000, Julien Grall wrote:
>>> +
>>> + for (cpu = 1; cpu < 4; cpu++) {
>>> + rc = brcm_cpu_power_on(va, cpu);
>>> + if (rc)
>>> + break;
>>> + }
>>
>> I don't like the for loop on the cores. In the future, it's possible
>> that Xen decides to only use 2 cores, so you will power unused core.
>> What about enabling power in brcm_cpu_up, if it's not too late?
>
> Not only in the future, we have command line options for these sorts of
> things already, which I think the ARM port obeys.
Are you talking about "max_cpus" parameter? If so, it's not yet
implemented on ARM. We rely on the number of cpus node in the device tree.
--
Julien Grall
next prev parent reply other threads:[~2013-11-12 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 23:37 [PATCH] xen/arm: Initial Broadcom A15 platform support Jon Fraser
2013-11-11 20:37 ` Julien Grall
2013-11-12 9:57 ` Ian Campbell
2013-11-12 12:52 ` Julien Grall [this message]
2013-11-12 13:48 ` Ian Campbell
2013-11-21 18:15 ` Jon Fraser
2013-11-22 9:58 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282248B.2080707@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=jfraser@broadcom.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).