From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] xen/arm: Initial Broadcom A15 platform
	support
Date: Tue, 12 Nov 2013 12:52:27 +0000
Message-ID: <5282248B.2080707@linaro.org>
References: <1383953844-31566-1-git-send-email-jfraser@broadcom.com>	
	<52813FF2.2000804@linaro.org>
	<1384250223.1883.36.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1384250223.1883.36.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jon Fraser <jfraser@broadcom.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org



On 11/12/2013 09:57 AM, Ian Campbell wrote:
> On Mon, 2013-11-11 at 20:37 +0000, Julien Grall wrote:
>>> +
>>> +    for (cpu = 1; cpu < 4; cpu++) {
>>> +        rc = brcm_cpu_power_on(va, cpu);
>>> +        if (rc)
>>> +            break;
>>> +    }
>>
>> I don't like the for loop on the cores. In the future, it's possible
>> that Xen decides to only use 2 cores, so you will power unused core.
>> What about enabling power in brcm_cpu_up, if it's not too late?
>
> Not only in the future, we have command line options for these sorts of
> things already, which I think the ARM port obeys.

Are you talking about "max_cpus" parameter? If so, it's not yet 
implemented on ARM. We rely on the number of cpus node in the device tree.

-- 
Julien Grall