From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] blkif: add indirect descriptors interface
 to	public headers
Date: Tue, 12 Nov 2013 15:54:45 +0100
Message-ID: <52824135.5040205@citrix.com>
References: <1384252612-22573-1-git-send-email-roger.pau@citrix.com>
	<9AAE0902D5BC7E449B7C8E4E778ABCD017021D@AMSPEX01CL01.citrite.net>
	<52823734.6020008@citrix.com>
	<52824CA60200007800102714@nat28.tlf.novell.com>
	<52824014.8050201@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1VgFMh-0003TE-7G
	for xen-devel@lists.xenproject.org; Tue, 12 Nov 2013 14:54:51 +0000
In-Reply-To: <52824014.8050201@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Paul Durrant <Paul.Durrant@citrix.com>, "Keir (Xen.org)" <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 12/11/13 15:49, David Vrabel wrote:
> On 12/11/13 14:43, Jan Beulich wrote:
>>>>> On 12.11.13 at 15:12, David Vrabel <david.vrabel@citrix.com> wrote:
>>> On 12/11/13 13:46, Paul Durrant wrote:
>>>>> +};
>>>>> +typedef struct blkif_request_indirect blkif_request_indirect_t;
>>>>> +
>>>>> +struct blkif_request_segment_aligned {
>>>>> +    grant_ref_t gref;            /* reference to I/O buffer frame        */
>>>>> +    /* @first_sect: first sector in frame to transfer (inclusive).   */
>>>>> +    /* @last_sect: last sector in frame to transfer (inclusive).     */
>>>>> +    uint8_t     first_sect, last_sect;
>>>
>>> Missing uint8_t padding here?
>>
>> Note that there are _two_ uint8_t-s.
> 
> Doh. That's poor style though.   A line per field, please.

I've mainly did it that way because that's how blkif_request_segment is
currently defined in blkif.h, but I can split it in two lines.