From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v15 08/19] pvh: vmx-specific changes
Date: Tue, 12 Nov 2013 15:06:08 +0000
Message-ID: <528243E0.3090603@eu.citrix.com>
References: <1384181841-22739-1-git-send-email-george.dunlap@eu.citrix.com>
	<1384181841-22739-9-git-send-email-george.dunlap@eu.citrix.com>
	<5282433F0200007800102619@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1VgFYE-0005Kb-Sy
	for xen-devel@lists.xenproject.org; Tue, 12 Nov 2013 15:06:47 +0000
In-Reply-To: <5282433F0200007800102619@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Eddie Dong <eddie.dong@intel.com>, Jun Nakajima <jun.nakajima@intel.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 11/12/2013 02:03 PM, Jan Beulich wrote:
>>>> On 11.11.13 at 15:57, George Dunlap <george.dunlap@eu.citrix.com> wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>> @@ -28,6 +28,7 @@
>>   #include <asm/msr.h>
>>   #include <asm/xstate.h>
>>   #include <asm/hvm/hvm.h>
>> +#include <asm/hvm/nestedhvm.h>
>
> Going through the changes below I can't see why you need this,
> and it also looks pretty far off for a PVH related change.

It's needed for the HVM_CR4_RESERVED_BITS macro, which calls 
nestedhvm_enabled().  I couldn't figure out a clean way to include 
nestedhvm.h from hvm.h (ran into weird compilation errors), so just gave 
up and added it in here.

  -George