From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: Physical memory start contraints in the Linux kernel (Was: Re: Xen osstest on Calxeda midway progress (Was: Re: [xen-unstable test] 21486: tolerable FAIL - PUSHED)) Date: Tue, 12 Nov 2013 16:40:56 +0100 Message-ID: <52824C08.70301@monstr.eu> References: <1383731526.26213.25.camel@kazak.uk.xensource.com> <1383736784.26213.72.camel@kazak.uk.xensource.com> <1383822868.26213.181.camel@kazak.uk.xensource.com> <1384250005.1883.35.camel@kazak.uk.xensource.com> <20131112132001.GJ16735@n2100.arm.linux.org.uk> <5282483E.1000101@monstr.eu> <20131112153904.GP16735@n2100.arm.linux.org.uk> Reply-To: monstr@monstr.eu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8076222151496119663==" Return-path: In-Reply-To: <20131112153904.GP16735@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Russell King - ARM Linux Cc: Andre Przywara , Ian Campbell , Arnd Bergmann , Stefano Stabellini , "xen.org" , xen-devel@lists.xensource.com, Stefano Stabellini , Olof Johansson , linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8076222151496119663== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="brK1DNukqVBxbe5uH4vHDTxvlhN52Fsfw" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --brK1DNukqVBxbe5uH4vHDTxvlhN52Fsfw Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/12/2013 04:39 PM, Russell King - ARM Linux wrote: > On Tue, Nov 12, 2013 at 04:24:46PM +0100, Michal Simek wrote: >> On 11/12/2013 02:20 PM, Russell King - ARM Linux wrote: >>> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c >>> index f52150d2ec00..1957d54198ad 100644 >>> --- a/arch/arm/kernel/setup.c >>> +++ b/arch/arm/kernel/setup.c >>> @@ -660,6 +660,17 @@ int __init arm_add_memory(u64 start, u64 size) >>> } >>> #endif >>> =20 >>> + if (aligned_start < PHYS_OFFSET) { >>> + if (aligned_start + size < PHYS_OFFSET) { >> >> just a note I sent to Russell. Here should be "<=3D" instead of just "= <" >> >>> + pr_info("Ignoring memory below PHYS_OFFSET: 0x%08llx-0x%08llx\n",= >>> + aligned_start, aligned_start + size); >>> + return -EINVAL; >>> + } >>> + >>> + size -=3D PHYS_OFFSET - aligned_start; >>> + aligned_start =3D PHYS_OFFSET; >> >> We should printk a message here to be aware that alignment was done. >=20 > Yep, you sent me an updated patch, I haven't added anything to my > kernel tree for about a week and a bit now as I want to get what's > already there into Linus' tree. Once that stuff has gone, I'll see > about adding some of these fixes we need into the queue. No problem. Take you time. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --brK1DNukqVBxbe5uH4vHDTxvlhN52Fsfw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKCTAgACgkQykllyylKDCH7AwCeM3yFgWdnB4+msRlU/a9ujqwW NoUAn3+HONmQU18Snt2cWIl/3wyMxAgs =fagn -----END PGP SIGNATURE----- --brK1DNukqVBxbe5uH4vHDTxvlhN52Fsfw-- --===============8076222151496119663== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8076222151496119663==--