From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH RESEND 09/12] libxc: numa-sched: enable
 getting/specifying per-vcpu node-affinity
Date: Tue, 12 Nov 2013 16:43:01 +0000
Message-ID: <52825A95.7010004@eu.citrix.com>
References: <20131105142844.30446.78671.stgit@Solace>
	<20131105143542.30446.5398.stgit@Solace>
	<20131112160144.GB11354@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20131112160144.GB11354@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Keir Fraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Li Yechen <lccycc123@gmail.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <JBeulich@suse.com>, Justin Weaver <jtweaver@hawaii.edu>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Matt Wilson <msw@amazon.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, Elena Ufimtseva <ufimtseva@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On 11/12/2013 04:01 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 05, 2013 at 03:35:42PM +0100, Dario Faggioli wrote:
>> by providing the proper get/set interfaces and wiring them
>> to the new domctl-s from the previous commit.
>
> s/previous commit/<title of the commit>/
>
>>
>> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>> ---
>>   tools/libxc/xc_domain.c |   82 +++++++++++++++++++++++++++++++++++++++++++++++
>>   tools/libxc/xenctrl.h   |   19 +++++++++++
>>   2 files changed, 101 insertions(+)
>>
>> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
>> index f8825a3..e44ad2e 100644
>> --- a/tools/libxc/xc_domain.c
>> +++ b/tools/libxc/xc_domain.c
>> @@ -272,6 +272,88 @@ out:
>>       return ret;
>>   }
>>
>> +int xc_vcpu_setnodeaffinity(xc_interface *xch,
>> +                            uint32_t domid,
>> +                            int vcpu,
>> +                            xc_nodemap_t nodemap)
>> +{
>> +    DECLARE_DOMCTL;
>> +    DECLARE_HYPERCALL_BUFFER(uint8_t, local);
>> +    int ret = -1;
>
> Ewww.. Could we just use regular -Exx for new xc_* calls?

I think the standard (which Dario is just following here) is to return 
-1 and set errno.  Since the failures are all after making calls to 
other xc functions, they should be setting errno properly, and we should 
be able to just leave it.

  -George