xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: "@oracle.com>"@aserz7021.oracle.com
Subject: [PATCH] xen: simplify balloon_first_page() with list_first_entry_or_null()
Date: Wed, 13 Nov 2013 19:44:45 +0800	[thread overview]
Message-ID: <5283662D.1010500@oracle.com> (raw)

From: Jie Liu <jeff.liu@oracle.com>

Simplify the code logic of balloon_first_page() by replacing
the combination of list_empty() and list_first_entry() with
list_first_entry_or_null().  As a net win, we can change this
routine to inline as now it's one line.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>

---
 drivers/xen/balloon.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index b232908..0e4ca20 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -157,11 +157,10 @@ static struct page *balloon_retrieve(bool prefer_highmem)
 	return page;
 }
 
-static struct page *balloon_first_page(void)
+static inline struct page *balloon_first_page(void)
 {
-	if (list_empty(&ballooned_pages))
-		return NULL;
-	return list_entry(ballooned_pages.next, struct page, lru);
+	return list_first_entry_or_null(&ballooned_pages,
+					struct page, lru);
 }
 
 static struct page *balloon_next_page(struct page *page)
-- 
1.7.9.5

             reply	other threads:[~2013-11-13 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 11:44 Jeff Liu [this message]
2013-11-13 12:09 ` [PATCH] xen: simplify balloon_first_page() with list_first_entry_or_null() David Vrabel
2013-11-13 12:54   ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5283662D.1010500@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc="@oracle.com>"@aserz7021.oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).