From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
ian.campbell@citrix.com, patches@linaro.org,
stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH V2] xen: Check if the range is valid in init_domheap_pages
Date: Wed, 13 Nov 2013 14:33:42 +0000 [thread overview]
Message-ID: <52838DC6.7060500@linaro.org> (raw)
In-Reply-To: <528396C60200007800102E5B@nat28.tlf.novell.com>
On 11/13/2013 02:12 PM, Jan Beulich wrote:
>>>> On 13.11.13 at 14:34, Julien Grall <julien.grall@linaro.org> wrote:
>
> I'm not following: If ps == pe and they're page aligned, then
>
> smfn = round_pgup(ps) >> PAGE_SHIFT;
> emfn = round_pgdown(pe) >> PAGE_SHIFT;
>
> produces smfn == emfn. So as said earlier - emfn = smfn - 1 requires
> the input to either be not page aligned, or pe < ps, both of which look
> invalid to me.
Right, my fault I didn't pay attention that ps and pe is non-aligned,
with the same value. That will result to my previous assertion.
In any case, init_domheap_pages seems to be able to handle non-aligned
address. Otherwise round_pg{up,down} is not necessary.
--
Julien Grall
next prev parent reply other threads:[~2013-11-13 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 13:15 [PATCH V2] xen: Check if the range is valid in init_domheap_pages Julien Grall
2013-11-13 13:23 ` Ian Campbell
2013-11-13 13:34 ` Julien Grall
2013-11-13 13:26 ` Jan Beulich
2013-11-13 13:34 ` Julien Grall
2013-11-13 14:12 ` Jan Beulich
2013-11-13 14:18 ` Ian Campbell
2013-11-13 14:32 ` Jan Beulich
2013-11-13 14:40 ` Ian Campbell
2013-11-13 14:33 ` Julien Grall [this message]
2013-11-13 13:38 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52838DC6.7060500@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).