From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v3 01/16] xenctx: clean up usage output
Date: Wed, 13 Nov 2013 12:24:59 -0500
Message-ID: <5283B5EB.7060603@terremark.com>
References: <1384193722-2916-1-git-send-email-dslutz@terremark.com>
	<1384193722-2916-2-git-send-email-dslutz@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1384193722-2916-2-git-send-email-dslutz@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 11/11/13 13:15, Don Slutz wrote:
> From: Don Slutz <dslutz@verizon.com>
>
> Fix usage formatting to be all the same.
>
> Fix usage display of default --kernel-start for 64 bit.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
>   tools/xentrace/xenctx.c | 17 +++++++++--------
>   1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> index 060e480..4490d82 100644
> --- a/tools/xentrace/xenctx.c
> +++ b/tools/xentrace/xenctx.c
> @@ -812,15 +812,16 @@ static void usage(void)
>   
>       printf("options:\n");
>       printf("  -f, --frame-pointers\n");
> -    printf("                    assume the kernel was compiled with\n");
> -    printf("                    frame pointers.\n");
> +    printf("                     assume the kernel was compiled with\n");
> +    printf("                     frame pointers.\n");
>       printf("  -s SYMTAB, --symbol-table=SYMTAB\n");
> -    printf("                    read symbol table from SYMTAB.\n");
> -    printf("  -S --stack-trace  print a complete stack trace.\n");
> -    printf("  -k, --kernel-start\n");
> -    printf("                    set user/kernel split. (default 0xc0000000)\n");
> -    printf("  -a --all          display more registers\n");
> -    printf("  -C --all-vcpus    print info for all vcpus\n");
> +    printf("                     read symbol table from SYMTAB.\n");
> +    printf("  -S, --stack-trace  print a complete stack trace.\n");
> +    printf("  -k kaddr, --kernel-start=kaddr\n");
When redoing patch #4 I noticed that kaddr was not added as KADDR. Also I started using <maddr> not MADDR.  Which is the preferred way?
    -Don Slutz
> +    printf("                     set user/kernel split. (default 0x"FMT_32B_WORD")\n",
> +        kernel_start);
> +    printf("  -a, --all          display more registers\n");
> +    printf("  -C, --all-vcpus    print info for all vcpus\n");
>   }
>   
>   int main(int argc, char **argv)