xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel List <xen-devel@lists.xen.org>,
	Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>
Subject: Request complete reversion of XSA-60 patches
Date: Wed, 13 Nov 2013 20:46:09 +0000	[thread overview]
Message-ID: <5283E511.6000004@citrix.com> (raw)

Hello,

Following CID 1128574 (Data race condition writing to
vcpu->arch.hvm_vcpu.cache_mode), I took a closer look at the expected
semantics surrounding domain->arch.hvm_domain.is_in_uc_mode

Embarrassingly, none of the reviewer (myself included) noticed that the
new "hvm_shadow_handle_cd()" was actually the regular CR0.CD switching
code for AMD SVM, which is now hidden behind an optional hvm_funcs
pointer only implemented in VT-x.

The changeset 62652c00efa55fb45374bcc92f7d96fc411aebb2 has therefore
caused a complete functional regression in AMD wrt CR0.CD handling.

>From my understanding after investigating, the new
"hvm_shadow_handle_cd()" function was actually common which needed doing
in all cases, otherwise HAP logdirty mode will break.  Therefore, this
change appears to have broken migration as well.

Furthermore, the series already missed correct cache flushing in certain
cases (e.g. writing the hypercall page).


I request that the series be reverted in it's entirety to minimise the
collateral damage until a full, complete and correct set of fixes can be
made.

~Andrew

             reply	other threads:[~2013-11-13 20:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 20:46 Andrew Cooper [this message]
2013-11-14 12:43 ` Was: Request complete reversion of XSA-60 patches Andrew Cooper
2013-11-15  8:12   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5283E511.6000004@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).