From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= Subject: Re: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen Date: Thu, 14 Nov 2013 12:50:53 +0100 Message-ID: <5284B91D.8080201@gmail.com> References: <20130715180006.GA2433@phenom.dumpdata.com> <527FEF3D.1050906@gmail.com> <20131113135650.GA2647@phenom.dumpdata.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0422420907246876591==" Return-path: In-Reply-To: <20131113135650.GA2647@phenom.dumpdata.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Konrad Rzeszutek Wilk Cc: The development of GNU GRUB , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0422420907246876591== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2HLRQGOCNKXJFHISAKCVN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HLRQGOCNKXJFHISAKCVN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13.11.2013 14:56, Konrad Rzeszutek Wilk wrote: > On Sun, Nov 10, 2013 at 09:40:29PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> On 15.07.2013 20:00, Konrad Rzeszutek Wilk wrote: >>> Hey, >>> >>> There is a discussion on the linux-kernel mailing list in which the >>> Linus states that "if you depend on any config file, you're broken >>> by definition" (https://lkml.org/lkml/2013/7/15/368). >>> >> Please try my grub_file branch: >> http://git.savannah.gnu.org/cgit/grub.git/log/?h=3Dphcoder/grub_file >> It should do what you want. >> >=20 > Oddly I get this after I installed it. >=20 > /sbin/grub-probe: error: failed to get canonical path of `'. >=20 > And I kind of fixed it by removing the 'set -e' at the start > of the file. >=20 > After that, and with me removing the /boot/config-3.12.0 file > it generates an proper entry in grub.cfg for the Xen payload! > Yeey! >=20 > The other thing I saw was that the 'root' option for Linux > ended up being 'root=3D' instead of the 'root=3DUUID=3Dblabla'. >=20 I've applied a small fix. It should fix both problems you report. Could you retest? > See here: >=20 > if [ x"$grub_platform" !=3D xxen \( x"$grub_cpu" =3D xi386 -o x"$grub_= cpu" =3D xx86_64 -o x"$grub_platform" =3D x \) ]; then > menuentry 'Fedora GNU/Linux, with Xen hypervisor' --class fedora --clas= s gnu-linux --class gnu --class os --class xen $menuentry_id_option 'xen-= gnulinux-simple-' { > insmod part_msdos=20 > insmod ext2 > set root=3D'hd0,msdos1' > if [ x$feature_platform_search_hint =3D xy ]; then > search --no-floppy --fs-uuid --set=3Droot --hint-bios=3Dhd0,msdos1 -= -hint-efi=3Dhd0,msdos1 --hint-baremetal=3Dahci0,msdos1 760e0266-1a60-462= 1-b332-0788cf687e33 > else > search --no-floppy --fs-uuid --set=3Droot 760e0266-1a60-4621-b332-07= 88cf687e33 > fi > echo 'Loading Xen xen ...' > if [ "$grub_platform" =3D "pc" -o "$grub_platform" =3D "" ]; th= en > xen_rm_opts=3D > else > xen_rm_opts=3D"no-real-mode edd=3Doff" > fi > multiboot /xen.gz placeholder guest_loglvl=3Dall com1=3D115200,8n1 con= sole=3Dcom1,vga loglvl=3Dall iommu=3Dno-amd-iommu-perdev-intremap,verbose= ,debug,no-intremap ${xen_rm_opts} > echo 'Loading Linux 3.12.0 ...' > module /vmlinuz-3.12.0 placeholder root=3D ro rd.md=3D0 rd.lvm=3D0 rd.= dm=3D0 rd.luks=3D0 loglevel=3D8 radeon.modeset=3D0 xen-pciback.hide=3D(0= 5:00.*) console=3Dhvc0=20 > echo 'Loading initial ramdisk ...' > module /initramfs-3.12.0.img > } >=20 ------enig2HLRQGOCNKXJFHISAKCVN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKEuSUACgkQmBXlbbo5nOvCqQD+LDPFNUwy+hr+RBAxExmuDs0U FUV7AA0DtPdQdOsDy1wA/RC99ju49Ydk7J3pNR7vTwVGnby8lEsw1pZD7M1lWh+6 =q8uc -----END PGP SIGNATURE----- ------enig2HLRQGOCNKXJFHISAKCVN-- --===============0422420907246876591== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel --===============0422420907246876591==--