From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH v5 19/19] libxl: build a device tree for ARM guests
Date: Thu, 14 Nov 2013 12:17:00 +0000 [thread overview]
Message-ID: <5284BF3C.9010307@linaro.org> (raw)
In-Reply-To: <1384417691.7059.25.camel@dagon.hellion.org.uk>
On 11/14/2013 08:28 AM, Ian Campbell wrote:
> On Thu, 2013-11-14 at 01:04 +0000, Julien Grall wrote:
>> Why didn't you try to use fdt_open_into? It should fit our usage: ie,
>> grow up the size of the device tree. Actually, DTC uses this solution
>> when the fdt needs to be resized.
>
> It seemed to be far more complex -- you would need to wrap every
> potentially failing fdt operation in a while loop which does the realloc
> and open into on ENOSPACE. Now that could be done by a macro but it
> would need to have much wider scope than here since it would be needed
> all the way down the call chain.
>
> This way the functions building each node don't need to worry about all
> that and only the toplevel needs to care. I'd be in favour of increasing
> the default allocation size before I wanted to switch the mechanism like
> this.
Ok. Then:
Acked-by: Julien Grall <julien.grall@linaro.org>
--
Julien Grall
next prev parent reply other threads:[~2013-11-14 12:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 18:10 [PATCH v5 00/17] xen: arm: 64-bit guest support and domU FDT autogeneration Ian Campbell
2013-11-13 18:11 ` [PATCH v5 01/19] HACK Ian Campbell
2013-11-13 18:15 ` Julien Grall
2013-11-13 20:15 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 02/19] xen: arm: drop LDFLAGS_DIRECT emulation specification Ian Campbell
2013-11-13 21:26 ` Julien Grall
2013-11-14 8:16 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 03/19] xen: update config.{sub, guess} for arm64 Ian Campbell
2013-11-13 18:11 ` [PATCH v5 04/19] xen: arm: Report aarch64 capability Ian Campbell
2013-11-13 18:11 ` [PATCH v5 05/19] xen: arm: Add comment regard arm64 zImage v0 vs v1 Ian Campbell
2013-11-13 18:11 ` [PATCH v5 06/19] xen: arm: move dom0 gic and timer device tree nodes under /xen/ Ian Campbell
2013-11-13 18:28 ` Stefano Stabellini
2013-11-13 20:18 ` Ian Campbell
2013-11-14 12:22 ` Stefano Stabellini
2013-11-19 9:52 ` Ian Campbell
2013-11-13 21:31 ` Julien Grall
2013-11-14 8:18 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 07/19] xen: arm: allocate dom0 memory separately from preparing the dtb Ian Campbell
2013-11-13 19:21 ` Stefano Stabellini
2013-11-13 20:18 ` Ian Campbell
2013-11-14 12:22 ` Stefano Stabellini
2013-11-13 21:34 ` Julien Grall
2013-11-14 8:23 ` Ian Campbell
2013-11-14 0:52 ` Julien Grall
2013-11-14 8:25 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 08/19] xen: arm: add enable-method to cpu nodes for arm64 guests Ian Campbell
2013-11-13 18:11 ` [PATCH v5 09/19] xen: arm: include header for for arch_do_{sys, dom}ctl prototype Ian Campbell
2013-11-13 18:11 ` [PATCH v5 10/19] xen: arm: implement XEN_DOMCTL_set_address_size Ian Campbell
2013-11-13 18:11 ` [PATCH v5 11/19] xen: arm: implement arch_set_info_guest for 64-bit vcpus Ian Campbell
2013-11-13 18:11 ` [PATCH v5 12/19] tools: check for libfdt when building for ARM Ian Campbell
2013-11-13 18:11 ` [PATCH v5 13/19] xen: arm: define guest virtual platform in API headers Ian Campbell
2013-11-13 18:11 ` [PATCH v5 14/19] libxc: arm: rename various bits of zimage load with 32 suffix Ian Campbell
2013-11-13 18:11 ` [PATCH v5 15/19] libxc: allow caller to specify guest rambase rather than hardcoding Ian Campbell
2013-11-13 18:11 ` [PATCH v5 16/19] libxc: arm: allow passing a device tree blob to the guest Ian Campbell
2013-11-14 0:47 ` Julien Grall
2013-11-19 12:36 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 17/19] libxc: support for arm64 Image format Ian Campbell
2013-11-14 1:17 ` Julien Grall
2013-11-19 12:39 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 18/19] libxc: arm64 vcpu initialisation Ian Campbell
2013-11-13 18:11 ` [PATCH v5 19/19] libxl: build a device tree for ARM guests Ian Campbell
2013-11-13 18:19 ` Stefano Stabellini
2013-11-14 1:04 ` Julien Grall
2013-11-14 8:28 ` Ian Campbell
2013-11-14 12:17 ` Julien Grall [this message]
2013-11-14 11:50 ` Ian Jackson
2013-11-14 12:17 ` Stefano Stabellini
2013-11-14 12:24 ` Julien Grall
2013-11-14 12:45 ` Ian Campbell
2013-11-14 14:01 ` Stefano Stabellini
2013-11-19 10:30 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284BF3C.9010307@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).