From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Patch v4 2/5] x86/hpet: Use singe apic vector
 rather than irq_descs for HPET interrupts
Date: Thu, 14 Nov 2013 15:56:14 +0000
Message-ID: <5284F29E.60802@citrix.com>
References: <1384365554-11017-1-git-send-email-andrew.cooper3@citrix.com>
	<1384365554-11017-3-git-send-email-andrew.cooper3@citrix.com>
	<20131114155203.GD42238@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20131114155203.GD42238@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 14/11/13 15:52, Tim Deegan wrote:
> Hi, 
>
> This looks pretty good to me. 
>
> At 17:59 +0000 on 13 Nov (1384361951), Andrew Cooper wrote:
>> +        else if ( fallback_deadline < STIME_MAX && fallback_deadline != -1 )
>> +        {
>> +            /*
>> +             * Else we want to reprogram the fallback HPET sooner if possible,
>> +             * but with all the spinlocking, it just might have passed.
>> +             */
>> +            ch = &hpet_events[fallback_idx];
>> +
>> +            spin_lock(&ch->lock);
>>  
>> -    if ( !(ch->flags & HPET_EVT_LEGACY) )
>> -        hpet_attach_channel(cpu, ch);
>> +            if ( ch->cpu != 1 && ch->next_event == fallback_deadline )
> DYM '!= -1' here?
>
> Apart from that, you can put 'Reviewed-by: Tim Deegan <tim@xen.org>'
> on patches 1-3.
>
> Cheers,
>
> Tim.
>

Eek - I do indeed.  (This is a very rare codepath, even when forced
using no-arat on newer hardware).

~Andrew