From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 1/7] xen: vNUMA support for guests. Date: Thu, 14 Nov 2013 21:43:52 +0000 Message-ID: <52854418.8050405@eu.citrix.com> References: <1384399569-23969-1-git-send-email-ufimtseva@gmail.com> <1384427912.29902.114.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384427912.29902.114.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: keir@xen.org, JBeulich@suse.com, stefano.stabellini@eu.citrix.com, msw@linux.com, lccycc123@gmail.com, xen-devel@lists.xen.org, Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org On 11/14/2013 11:18 AM, Dario Faggioli wrote: >> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h >> index a057069..bc61bab 100644 >> --- a/xen/include/xen/domain.h >> +++ b/xen/include/xen/domain.h >> @@ -89,4 +89,14 @@ extern unsigned int xen_processor_pmbits; >> >> extern bool_t opt_dom0_vcpus_pin; >> >> +struct domain_vnuma_info { >> + uint nr_vnodes; >> + uint *vdistance; >> + uint *vcpu_to_vnode; >> + uint *vnode_numamap; >> + struct vmemrange *vmemrange; >> +}; >> + > I think you can kill the 'domain_' prefix. It's pretty clear this is a > per-domain thing, from the fact that it lives inside struct domain. Still, it doesn't hurt to have a little bit of extra context. If you look above in this file, for example, it has "vcpu_guest_context" -- even though it should be obvious that guest context is per-vcpu. :-) > >> +void domain_vnuma_destroy(struct domain_vnuma_info *v); >> + > Why do you need to declare this function here? Isn't this used only in > domain.c ? In fact, it should probably be static. -George