From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH RFC v2] pvh: clearly specify used parameters in vcpu_guest_context Date: Tue, 19 Nov 2013 11:10:59 +0000 Message-ID: <528B4743.5020500@eu.citrix.com> References: <1384798711-4255-1-git-send-email-roger.pau@citrix.com> <528B3EA3.9090008@eu.citrix.com> <528B4090.40608@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VijCy-0005Bx-3F for xen-devel@lists.xenproject.org; Tue, 19 Nov 2013 11:11:04 +0000 In-Reply-To: <528B4090.40608@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Cc: xen-devel@lists.xenproject.org, Keir Fraser , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMTEvMTkvMjAxMyAxMDo0MiBBTSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToKPiBPbiAxOS8x MS8xMyAxMTozNCwgR2VvcmdlIER1bmxhcCB3cm90ZToKPj4gT24gMTEvMTgvMjAxMyAwNjoxOCBQ TSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+Pj4gVGhlIGFpbSBvZiB0aGlzIHBhdGNoIGlzIHRv IGRlZmluZSBhIHN0YWJsZSB3YXkgaW4gd2hpY2ggUFZIIGlzCj4+PiBnb2luZyB0byBkbyBBUCBi cmluZ3VwLgo+Pj4KPj4+IFNpbmNlIHdlIGFyZSBydW5uaW5nIGluc2lkZSBvZiBhIEhWTSBjb250 YWluZXIsIFBWSCBzaG91bGQgb25seSBuZWVkCj4+PiB0byBzZXQgZmxhZ3MsIGNyMyBhbmQgdXNl cl9yZWdzIGluIG9yZGVyIHRvIGJyaW5nIHVwIGEgdkNQVSwgdGhlIHJlc3QKPj4+IGNhbiBiZSBz ZXQgb25jZSB0aGUgdkNQVSBpcyBzdGFydGVkIHVzaW5nIHRoZSBiYXJlIG1ldGFsIG1ldGhvZHMu Cj4+PiBBZGRpdGlvbmFsbHksIHRoZSBndWVzdCBjYW4gYWxzbyBzZXQgY3IwIGFuZCBjcjQsIGFu ZCB0aG9zZSB2YWx1ZXMKPj4+IHdpbGwgYmUgYXBwZW5kZWQgdG8gdGhlIGRlZmF1bHQgdmFsdWVz IHNldCBieSBYZW4uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9n ZXIucGF1QGNpdHJpeC5jb20+Cj4+PiBDYzogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBl dS5jaXRyaXguY29tPgo+Pj4gQ2M6IE11a2VzaCBSYXRob3IgPG11a2VzaC5yYXRob3JAb3JhY2xl LmNvbT4KPj4+IENjOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+Cj4+PiBDYzogVGlt IERlZWdhbiA8dGltQHhlbi5vcmc+Cj4+PiBDYzogS2VpciBGcmFzZXIgPGtlaXJAeGVuLm9yZz4K Pj4+IC0tLQo+Pj4gICAgeGVuL2FyY2gveDg2L2RvbWFpbi5jICAgICAgICAgICAgIHwgICAyNCAr KysrKysrKysrKysrKysrLS0tLS0tLS0KPj4+ICAgIHhlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5j ICAgICAgICB8ICAgIDYgKy0tLS0tCj4+PiAgICB4ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9odm0u aCAgICAgfCAgICA2ICsrKy0tLQo+Pj4gICAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L3hl bi5oIHwgICAgOCArKysrLS0tLQo+Pj4gICAgNCBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25z KCspLCAyMCBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2Rv bWFpbi5jIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jCj4+PiBpbmRleCBhMzg2OGY5Li41MTMxMWZj IDEwMDY0NAo+Pj4gLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCj4+PiArKysgYi94ZW4vYXJj aC94ODYvZG9tYWluLmMKPj4+IEBAIC01MSw2ICs1MSw3IEBACj4+PiAgICAjaW5jbHVkZSA8YXNt L2ZpeG1hcC5oPgo+Pj4gICAgI2luY2x1ZGUgPGFzbS9odm0vaHZtLmg+Cj4+PiAgICAjaW5jbHVk ZSA8YXNtL2h2bS9zdXBwb3J0Lmg+Cj4+PiArI2luY2x1ZGUgPGFzbS9odm0vbmVzdGVkaHZtLmg+ Cj4+PiAgICAjaW5jbHVkZSA8YXNtL2RlYnVncmVnLmg+Cj4+PiAgICAjaW5jbHVkZSA8YXNtL21z ci5oPgo+Pj4gICAgI2luY2x1ZGUgPGFzbS90cmFwcy5oPgo+Pj4gQEAgLTcwNCw5ICs3MDUsMTMg QEAgaW50IGFyY2hfc2V0X2luZm9fZ3Vlc3QoCj4+PiAgICAgICAgICAgIC8qIFBWSCAzMmJpdGZp eG1lICovCj4+PiAgICAgICAgICAgIEFTU0VSVCghY29tcGF0KTsKPj4+Cj4+PiAtICAgICAgICBp ZiAoIGMoY3RybHJlZ1sxXSkgfHwgYyhsZHRfYmFzZSkgfHwgYyhsZHRfZW50cykgfHwKPj4+ICsg ICAgICAgIGlmICggKGMoY3RybHJlZ1swXSkgJiBIVk1fQ1IwX0dVRVNUX1JFU0VSVkVEX0JJVFMp IHx8Cj4+PiArICAgICAgICAgICAgIChjKGN0cmxyZWdbNF0pICYgSFZNX0NSNF9HVUVTVF9SRVNF UlZFRF9CSVRTKHYpKSB8fAo+Pgo+PiBHb29kIGlkZWEuIDotKQo+Pgo+Pj4gKyAgICAgICAgICAg ICBjKGN0cmxyZWdbMV0pIHx8IGMoY3RybHJlZ1syXSkgfHwgYyhjdHJscmVnWzVdKSB8fAo+Pj4g KyAgICAgICAgICAgICBjKGN0cmxyZWdbNl0pIHx8IGMoY3RybHJlZ1s3XSkgfHwgYyhsZHRfYmFz ZSkgfHwKPj4+IGMobGR0X2VudHMpIHx8Cj4+PiAgICAgICAgICAgICAgICAgYyh1c2VyX3JlZ3Mu Y3MpIHx8IGModXNlcl9yZWdzLnNzKSB8fCBjKHVzZXJfcmVncy5lcykgfHwKPj4+ICAgICAgICAg ICAgICAgICBjKHVzZXJfcmVncy5kcykgfHwgYyh1c2VyX3JlZ3MuZnMpIHx8IGModXNlcl9yZWdz LmdzKSB8fAo+Pj4gKyAgICAgICAgICAgICBjKGtlcm5lbF9zcykgfHwgYyhrZXJuZWxfc3ApIHx8 IGMubmF0LT5nc19iYXNlX2tlcm5lbCB8fAo+Pj4gICAgICAgICAgICAgICAgIGMubmF0LT5nZHRf ZW50cyB8fCBjLm5hdC0+ZnNfYmFzZSB8fCBjLm5hdC0+Z3NfYmFzZV91c2VyICkKPj4+ICAgICAg ICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4gICAgICAgIH0KPj4+IEBAIC03NDUsMTcgKzc1 MCwyMCBAQCBpbnQgYXJjaF9zZXRfaW5mb19ndWVzdCgKPj4+Cj4+PiAgICAgICAgaWYgKCBoYXNf aHZtX2NvbnRhaW5lcl92Y3B1KHYpICkKPj4+ICAgICAgICB7Cj4+PiAtICAgICAgICAvKgo+Pj4g LSAgICAgICAgICogTkI6IFRGX2tlcm5lbF9tb2RlIGlzIHNldCB1bmNvbmRpdGlvbmFsbHkgZm9y IEhWTSBndWVzdHMsCj4+PiAtICAgICAgICAgKiBzbyB3ZSBhbHdheXMgdXNlIHRoZSBnc19iYXNl X2tlcm5lbCBoZXJlLiBJZiB3ZSBjaGFuZ2UgdGhpcwo+Pj4gLSAgICAgICAgICogZnVuY3Rpb24g dG8gaW1pdGF0ZSB0aGUgUFYgZnVuY3Rpb25hbGl0eSwgd2UnbGwgbmVlZCB0bwo+Pj4gLSAgICAg ICAgICogbWFrZSBpdCBwYXkgYXR0ZW50aW9uIHRvIHRoZSBrZXJuZWwgYml0Lgo+Pj4gLSAgICAg ICAgICovCj4+PiAtICAgICAgICBodm1fc2V0X2luZm9fZ3Vlc3QodiwgY29tcGF0ID8gMCA6IGMu bmF0LT5nc19iYXNlX2tlcm5lbCk7Cj4+Cj4+IEkgdGhpbmsgd2Ugc3RpbGwgbmVlZCB0byBjYWxs IGh2bV9zZXRfaW5mb19ndWVzdCgpIGhlcmUgLS0gdGhlcmUgaXMKPj4gb3RoZXIgc3R1ZmYgYmVp bmcgc2V0IHVwLCBhbmQgaXQgd2FzIGNhbGxlZCAod2l0aG91dCB0aGUgZXh0cmEgYXJndW1lbnQK Pj4gZm9yIGdzX2Jhc2Vfa2VybmVsKSBiZWZvcmUgdGhlIFBWSCBwYXRjaCBzZXJpZXMgd2VudCBp bi4KPj4KPj4gKFNlZSBjL3MgMzViMWUwNy4pCj4KPiBJIHNlZSwgSSB3aWxsIHJlc3RvcmUgdGhl IGh2bV9zZXRfaW5mb19ndWVzdCBjYWxsLCBnb29kIGNhdGNoLgo+Cj4+Cj4+Pgo+Pj4gICAgICAg ICAgICBpZiAoIGlzX2h2bV92Y3B1KHYpIHx8IHYtPmlzX2luaXRpYWxpc2VkICkKPj4+ICAgICAg ICAgICAgICAgIGdvdG8gb3V0Owo+Pj4KPj4+ICsgICAgICAgIGlmICggYy5uYXQtPmN0cmxyZWdb MF0gKSB7Cj4+PiArICAgICAgICAgICAgdi0+YXJjaC5odm1fdmNwdS5ndWVzdF9jclswXSB8PSBj Lm5hdC0+Y3RybHJlZ1swXTsKPj4+ICsgICAgICAgICAgICBodm1fdXBkYXRlX2d1ZXN0X2NyKHYs IDApOwo+Pj4gKyAgICAgICAgfQo+Pj4gKwo+Pj4gKyAgICAgICAgaWYgKCBjLm5hdC0+Y3RybHJl Z1s0XSApIHsKPj4+ICsgICAgICAgICAgICB2LT5hcmNoLmh2bV92Y3B1Lmd1ZXN0X2NyWzRdIHw9 IGMubmF0LT5jdHJscmVnWzRdOwo+Pj4gKyAgICAgICAgICAgIGh2bV91cGRhdGVfZ3Vlc3RfY3Io diwgNCk7Cj4+PiArICAgICAgICB9Cj4+Cj4+IEkgdGhvdWdodCB0aGUgaWRlYSB3YXMgdGhhdCBo ZSB3b3VsZCBzZXQgY3IwLCBjcjMsIGFuZCBjcjQgZm9yIGFsbCBIVk0KPj4gZ3Vlc3RzLCByYXRo ZXIgdGhhbiBzcGVjaWFsLWNhc2luZyBQVkggZ3Vlc3RzPwo+Cj4gV2VsbCwgSSB3YXMganVzdCB0 cnlpbmcgdG8gbWFrZSB0aGUgUFZIIEFQIGJyaW5ndXAgaW50ZXJmYWNlIHN0YWJsZSwKPiB3aXRo b3V0IG1lc3NpbmcgbXVjaCB3aXRoIEhWTSAobm90IHRoYXQgd2Ugc2hvdWxkbid0IGFpbSB0byBk byBpdCBmb3IKPiBIVk0gZ3Vlc3RzIGFsc28pLCBidXQgSSB0aGluayB0aGUgbWFpbiBjb25jZXJu IG5vdyBpcyByZWxlYXNpbmcgNC40IHdpdGgKPiBhIHN0YWJsZSBpbnRlcmZhY2UgZm9yIFBWSCBn dWVzdHMuCgpSaWdodCAtLSBJIGd1ZXNzIGl0J3MgYmV0dGVyIHNhZmUgdGhhbiBzb3JyeSB3cnQg Y2hhbmdpbmcgdGhlIEhWTSBwYXRoczsgCndlIGNhbiBtYWtlIGl0IFBWSCBmb3Igbm93LCBhbmQg bWFrZSBpdCBtb3JlIGdlbmVyaWMgZm9yIDQuNS4KCiAgLUdlb3JnZQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK