From: George Dunlap <george.dunlap@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Simon Martin <smartin@milliways.cl>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Robert VanVossen <robert.vanvossen@dornerworks.com>,
xen-devel@lists.xen.org,
Nathan Studer <nate.studer@dornerworks.com>
Subject: Re: [PATCH 2/3] arinc: Add cpu-pool support to scheduler.
Date: Tue, 19 Nov 2013 11:18:49 +0000 [thread overview]
Message-ID: <528B4919.3030404@eu.citrix.com> (raw)
In-Reply-To: <528B3DBA.9020802@citrix.com>
On 11/19/2013 10:30 AM, Andrew Cooper wrote:
> On 18/11/2013 20:16, Nathan Studer wrote:
>> @@ -450,7 +454,7 @@ a653sched_alloc_pdata(const struct scheduler *ops, int cpu)
>> static void
>> a653sched_free_pdata(const struct scheduler *ops, void *pcpu, int cpu)
>> {
>> - /* nop */
>> + /* NOP */
>
> This change seems a little pointless.
So is this criticism. If the maintainer thinks the comment would look
better upper-case, he can change it.
-George
next prev parent reply other threads:[~2013-11-19 11:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:16 [PATCH 0/3] arinc: Implement cpu-pool support Nathan Studer
2013-11-18 20:16 ` [PATCH 1/3] arinc: whitespace and formatting fixes Nathan Studer
2013-11-19 9:54 ` Andrew Cooper
2013-11-19 11:30 ` George Dunlap
2013-11-18 20:16 ` [PATCH 2/3] arinc: Add cpu-pool support to scheduler Nathan Studer
2013-11-19 10:30 ` Andrew Cooper
2013-11-19 11:18 ` George Dunlap [this message]
2013-11-19 11:33 ` Andrew Cooper
2013-11-19 13:01 ` Nate Studer
2013-11-19 13:58 ` Nate Studer
2013-11-19 14:04 ` Nate Studer
2013-11-19 18:16 ` Andrew Cooper
2013-11-19 11:30 ` George Dunlap
2013-11-18 20:16 ` [PATCH 3/3] arinc: Add poolid parameter to scheduler get/set functions Nathan Studer
2013-11-19 10:32 ` Andrew Cooper
2013-11-19 11:32 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B4919.3030404@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=nate.studer@dornerworks.com \
--cc=robert.vanvossen@dornerworks.com \
--cc=smartin@milliways.cl \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).