Re: [PATCH v3 02/14] libxl: sanitize error handling in libxl_get_max_{cpus, nodes}

[George Dunlap <george.dunlap@eu.citrix.com>]

On 11/18/2013 06:16 PM, Dario Faggioli wrote:
> as well as both error handling and logging in libxl_cpu_bitmap_alloc
> and libxl_node_bitmap_alloc.
>
> Now libxl_get_max_{cpus,nodes} either return a positive number, or
> a libxl error code. Thanks to that, it is possible to fix loggig for
> the two bitmap allocation functions, which now happens _inside_ the
> functions themselves, and report what happens more accurately.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>

With one caveat...

> diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
> index 682f874..2a51c9c 100644
> --- a/tools/libxl/libxl_utils.c
> +++ b/tools/libxl/libxl_utils.c
> @@ -645,6 +645,46 @@ char *libxl_bitmap_to_hex_string(libxl_ctx *ctx, const libxl_bitmap *bitmap)
>       return q;
>   }
>
> +inline int libxl_cpu_bitmap_alloc(libxl_ctx *ctx,
> +                                  libxl_bitmap *cpumap,
> +                                  int max_cpus)

Stray 'inline'. :-)

  -George