From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v6 03/16] xen: arm: move dom0 gic and timer device tree nodes under /xen-core-devices/ Date: Tue, 19 Nov 2013 16:29:30 +0000 Message-ID: <528B91EA.7040501@linaro.org> References: <1384865949.30014.86.camel@kazak.uk.xensource.com> <1384866024-13108-3-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384866024-13108-3-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/19/2013 01:00 PM, Ian Campbell wrote: > Julien observed that we were relying on the provided host DTB supplying > suitable #address-cells and #size-cells values to allow us to represent these > addresses, which may not reliably be the case. Moving these under our own > known (somewhat analogous to the use of /soc/ or /motherboard/ on some > platforms) allows us to control these sizes. > > Since the new node is created out of thin air it does not have a corresponding > struct dt_device_node and therefore we cannot use dt_n_addr_cells or > dt_n_size_cells, we can use hardcoded constants instead. For the same reason > we define and use set_xen_range instead of dt_set_range. > > The hypervisor, cpus and psci node all either defined #foo-cells for their > children or do not contain reg properties and therefore can remain at the top > level. > > The logging in make_gic_node was inconsistent. Fix it. > > Signed-off-by: Ian Campbell Acked-by: Julien Grall -- Julien Grall