From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, patches@linaro.org, tim@xen.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] xen/arm: Panic if we are unable to initialize platform timer
Date: Tue, 19 Nov 2013 16:39:03 +0000 [thread overview]
Message-ID: <528B9427.1000104@linaro.org> (raw)
In-Reply-To: <1384872474.30014.119.camel@kazak.uk.xensource.com>
On 11/19/2013 02:47 PM, Ian Campbell wrote:
> On Fri, 2013-11-15 at 15:58 +0000, Stefano Stabellini wrote:
>> On Fri, 15 Nov 2013, Julien Grall wrote:
>>> The caller of xen_init_time, start_xen, doesn't check the return value
>>> of the function. Xen will silently ignore the error and continue.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> I did wonder if it might be worth pushing the panic down into
> platform_time_init, so that the message could be more specific. But that
> seems like it relies on platform code to be more aware of when to panic
> and to use consistent wording etc. So all in all I think it is better
> here.
I thought about this solution. I didn't find good argument for one of
these solutions. So, by default, I choose to panic in init_xen_time.
--
Julien Grall
next prev parent reply other threads:[~2013-11-19 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 15:27 [PATCH] xen/arm: ioremap_attr: return NULL is __vmap failed Julien Grall
2013-11-15 15:27 ` [PATCH] xen/arm: Panic if platform initialization failed Julien Grall
2013-11-15 15:59 ` Stefano Stabellini
2013-11-19 14:50 ` Ian Campbell
2013-11-15 15:27 ` [PATCH] xen/arm: Panic if we are unable to initialize platform timer Julien Grall
2013-11-15 15:58 ` Stefano Stabellini
2013-11-19 14:47 ` Ian Campbell
2013-11-19 16:39 ` Julien Grall [this message]
2013-11-15 15:45 ` [PATCH] xen/arm: ioremap_attr: return NULL is __vmap failed Andrew Cooper
2013-11-15 16:04 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B9427.1000104@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).