From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Panic if we are unable to initialize platform timer Date: Tue, 19 Nov 2013 16:39:03 +0000 Message-ID: <528B9427.1000104@linaro.org> References: <1384529257-7590-1-git-send-email-julien.grall@linaro.org> <1384529257-7590-3-git-send-email-julien.grall@linaro.org> <1384872474.30014.119.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VioKR-00088R-Qr for xen-devel@lists.xenproject.org; Tue, 19 Nov 2013 16:39:08 +0000 Received: by mail-ee0-f41.google.com with SMTP id t10so2172083eei.28 for ; Tue, 19 Nov 2013 08:39:06 -0800 (PST) In-Reply-To: <1384872474.30014.119.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, patches@linaro.org, tim@xen.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 11/19/2013 02:47 PM, Ian Campbell wrote: > On Fri, 2013-11-15 at 15:58 +0000, Stefano Stabellini wrote: >> On Fri, 15 Nov 2013, Julien Grall wrote: >>> The caller of xen_init_time, start_xen, doesn't check the return value >>> of the function. Xen will silently ignore the error and continue. >>> >>> Signed-off-by: Julien Grall >> >> Acked-by: Stefano Stabellini > > Acked-by: Ian Campbell > > I did wonder if it might be worth pushing the panic down into > platform_time_init, so that the message could be more specific. But that > seems like it relies on platform code to be more aware of when to panic > and to use consistent wording etc. So all in all I think it is better > here. I thought about this solution. I didn't find good argument for one of these solutions. So, by default, I choose to panic in init_xen_time. -- Julien Grall