From: George Dunlap <george.dunlap@eu.citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, msw@linux.com,
lccycc123@gmail.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, JBeulich@suse.com,
Elena Ufimtseva <ufimtseva@gmail.com>
Subject: Re: [PATCH v3 7/7] xl: docs for xl config vnuma options
Date: Tue, 19 Nov 2013 17:26:39 +0000 [thread overview]
Message-ID: <528B9F4F.2030303@eu.citrix.com> (raw)
In-Reply-To: <1384881830.19880.150.camel@Abyss>
On 11/19/2013 05:23 PM, Dario Faggioli wrote:
> Again, only one quick note (for now).
>
> On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote:
>> xl: docs for xl config vnuma options
>>
> Changes to the documentation should happen in the same patch that
> introduces the feature or modifies the behavior.
Although there is a certain logic to that, if there are major
documentation changes, I find that having the documentation in the same
exact patch makes the patch a lot harder to review. I much prefer to
have the documentation happen at the end of the patch series, unless
it's something really minor. (Although I generally won't complain
either way.)
-George
prev parent reply other threads:[~2013-11-19 17:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:24 [PATCH v3 0/7] vNUMA introduction Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 1/7] xen: vNUMA support for PV guests Elena Ufimtseva
2013-11-19 7:41 ` Dario Faggioli
2013-11-19 14:01 ` Jan Beulich
2013-11-19 14:35 ` Dario Faggioli
2013-11-19 14:48 ` Jan Beulich
2013-11-19 15:42 ` Dario Faggioli
2013-11-19 15:54 ` Jan Beulich
2013-11-19 16:36 ` Dario Faggioli
2013-11-19 16:43 ` Jan Beulich
2013-11-26 21:59 ` Elena Ufimtseva
2013-11-27 1:23 ` Dario Faggioli
2013-11-27 8:14 ` Jan Beulich
2013-12-02 17:06 ` Elena Ufimtseva
2013-12-02 17:09 ` Jan Beulich
2013-12-02 17:27 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 2/7] libxc: Plumb Xen with vNUMA topology for domain Elena Ufimtseva
2013-11-19 8:37 ` Dario Faggioli
2013-11-19 14:03 ` Konrad Rzeszutek Wilk
2013-11-19 22:06 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 3/7] libxc: vnodes allocation on NUMA nodes Elena Ufimtseva
2013-11-19 14:22 ` Dario Faggioli
2013-11-18 20:24 ` [PATCH v3 4/7] libxl: vNUMA supporting interface Elena Ufimtseva
2013-11-19 18:37 ` Dario Faggioli
2013-11-21 9:59 ` Li Yechen
2013-11-26 22:14 ` Elena Ufimtseva
2013-11-26 23:21 ` Dario Faggioli
2013-12-02 18:14 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 5/7] libxl: vNUMA configuration parser Elena Ufimtseva
2013-11-19 17:20 ` Dario Faggioli
2013-11-20 22:48 ` Matthew Daley
2013-11-21 3:20 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 6/7] xen: adds vNUMA info debug-key u Elena Ufimtseva
2013-11-22 18:15 ` Dario Faggioli
2013-11-18 20:24 ` [PATCH v3 7/7] xl: docs for xl config vnuma options Elena Ufimtseva
2013-11-19 17:23 ` Dario Faggioli
2013-11-19 17:26 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B9F4F.2030303@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=lccycc123@gmail.com \
--cc=msw@linux.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=ufimtseva@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).