From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 7/7] xl: docs for xl config vnuma options Date: Tue, 19 Nov 2013 17:26:39 +0000 Message-ID: <528B9F4F.2030303@eu.citrix.com> References: <1384806262-12532-1-git-send-email-ufimtseva@gmail.com> <1384806262-12532-8-git-send-email-ufimtseva@gmail.com> <1384881830.19880.150.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384881830.19880.150.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, msw@linux.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org On 11/19/2013 05:23 PM, Dario Faggioli wrote: > Again, only one quick note (for now). > > On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote: >> xl: docs for xl config vnuma options >> > Changes to the documentation should happen in the same patch that > introduces the feature or modifies the behavior. Although there is a certain logic to that, if there are major documentation changes, I find that having the documentation in the same exact patch makes the patch a lot harder to review. I much prefer to have the documentation happen at the end of the patch series, unless it's something really minor. (Although I generally won't complain either way.) -George