From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v6 10/16] xen: arm: define guest virtual platform in API headers Date: Tue, 19 Nov 2013 17:58:17 +0000 Message-ID: <528BA6B9.4010302@citrix.com> References: <1384865949.30014.86.camel@kazak.uk.xensource.com> <1384866024-13108-10-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384866024-13108-10-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/19/2013 01:00 PM, Ian Campbell wrote: > The tools and the hypervisor need to agree on various aspects of the guest > environment, such as interrupt numbers, memory layout, initial register values > for registers which are implementation defined etc. Therefore move the > associated defines into the public interface headers, or create them as > necessary. > > This just exposes the current de-facto standard guest layout, which may be > subject to change in the future. This deliberately does not make the guest > layout dynamic since there is currently no need. > > These values should not be exposed to guests, they should find these things > out via device tree or should not be relying on implementation defined > defaults. > > Various bits of the hypervisor needed to change to configure dom0 with the real > platform values while using the virtual platform configuration for guests. > Arrange for this where appropriate and plumb through as needed. > > We also need to expose some 64-bit values (e.g. PSR_GUEST64_INIT) for the > benefit of 32 bit toolstacks building 64 bit guests. > > Signed-off-by: Ian Campbell > Acked-by: Stefano Stabellini > Acked-by: Julien Grall Hi, I have just noticed that this patch breaks dom0 boot on most of ARM platform. I have sent a separate patch to fix this issue. See: https://patches.linaro.org/21632/ Cheers, -- Julien Grall