From: Jim Fehlig <jfehlig@suse.com>
To: Bamvor Jian Zhang <bjzhang@suse.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Ian.Campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 0/3] libxl: event system: SIGCHLD related fixes
Date: Tue, 19 Nov 2013 21:28:34 -0700 [thread overview]
Message-ID: <528C3A72.5020008@suse.com> (raw)
In-Reply-To: <1384280861-14788-1-git-send-email-ian.jackson@eu.citrix.com>
Ian Jackson wrote:
> libxl's SIGCHLD handler is broken if libxl_sigchld_owner_libxl_always
> and does not always work correctly with the fd registration system.
>
> 1/3 libxl: event system: pass gc, not just ctx, to internal
> 2/3 libxl: event system: Make
> 3/3 libxl: event system: properly register the SIGCHLD
>
> This is v2 of this series because when I reviewed it myself I found
> that there was a critical missing ! in perhaps_removehandler, which
> would remove the handler iff it was needed. IMO this shows the
> weakness of my testing arrangements.
>
> I'd really appreciate some feedback on this from Bamvor or Jim.
>
Hrm, I haven't followed this thread and am not familiar with the details...
Bamvor, have you reviewed/tested Ian's patches to see if they resolve
the issue you originally raised in this thread?
Thanks,
Jim
next prev parent reply other threads:[~2013-11-20 4:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 9:22 [PATCH 0/2] question on libxl ao Bamvor Jian Zhang
2013-11-05 9:22 ` [PATCH 1/2] expose child fd in order to handle child exit in libvirt Bamvor Jian Zhang
2013-11-05 16:05 ` [PATCH 0/2] question on libxl ao [and 1 more messages] Ian Jackson
2013-11-05 19:19 ` [PATCH 0/3] libxl: event system: SIGCHLD related fixes Ian Jackson
2013-11-05 19:19 ` [PATCH 1/3] libxl: event system: pass gc, not just ctx, to internal sigchld manipulators Ian Jackson
2013-11-06 10:30 ` Ian Campbell
2013-11-05 19:19 ` [PATCH 2/3] libxl: event system: Make libxl_sigchld_owner_libxl_always work Ian Jackson
2013-11-06 10:34 ` Ian Campbell
2013-11-05 19:19 ` [PATCH 3/3] libxl: event system: properly register the SIGCHLD self-pipe Ian Jackson
2013-11-06 10:36 ` Ian Campbell
2013-11-06 10:38 ` [PATCH 0/3] libxl: event system: SIGCHLD related fixes Ian Campbell
2013-11-06 12:08 ` Ian Jackson
2013-11-12 18:27 ` [PATCH v2 " Ian Jackson
2013-11-12 18:27 ` [PATCH 1/3] libxl: event system: pass gc, not just ctx, to internal sigchld manipulators Ian Jackson
2013-11-12 18:27 ` [PATCH 2/3] libxl: event system: Make libxl_sigchld_owner_libxl_always work Ian Jackson
2013-11-12 18:27 ` [PATCH 3/3] libxl: event system: properly register the SIGCHLD self-pipe Ian Jackson
2013-11-13 10:02 ` [PATCH v2 0/3] libxl: event system: SIGCHLD related fixes Ian Campbell
2013-11-21 18:49 ` Ian Jackson
2013-11-20 4:28 ` Jim Fehlig [this message]
2013-11-20 15:22 ` 答复： " Bamvor Jian Zhang
2013-11-20 16:40 ` 答复： Re: [PAT CH " Ian Jackson
2013-11-07 3:00 ` [PATCH 0/2] question on libxl ao [and 1 more messages] Bamvor Jian Zhang
2013-11-05 19:23 ` [PATCH 0/2] question on libxl ao [and 1 more messages] " Ian Jackson
2013-11-05 9:22 ` [PATCH 2/2] call ao_how callback explicitly Bamvor Jian Zhang
2013-11-05 15:51 ` Ian Jackson
2013-11-07 14:51 ` Bamvor Jian Zhang
2013-11-07 17:03 ` Ian Jackson
2013-11-08 13:17 ` Bamvor Jian Zhang
2013-11-08 16:07 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C3A72.5020008@suse.com \
--to=jfehlig@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=bjzhang@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).