From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH v2 0/3] libxl: event system: SIGCHLD related fixes Date: Tue, 19 Nov 2013 21:28:34 -0700 Message-ID: <528C3A72.5020008@suse.com> References: <21114.12598.728707.578344@mariner.uk.xensource.com> <1384280861-14788-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384280861-14788-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Bamvor Jian Zhang Cc: Ian Jackson , Ian.Campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > libxl's SIGCHLD handler is broken if libxl_sigchld_owner_libxl_always > and does not always work correctly with the fd registration system. > > 1/3 libxl: event system: pass gc, not just ctx, to internal > 2/3 libxl: event system: Make > 3/3 libxl: event system: properly register the SIGCHLD > > This is v2 of this series because when I reviewed it myself I found > that there was a critical missing ! in perhaps_removehandler, which > would remove the handler iff it was needed. IMO this shows the > weakness of my testing arrangements. > > I'd really appreciate some feedback on this from Bamvor or Jim. > Hrm, I haven't followed this thread and am not familiar with the details... Bamvor, have you reviewed/tested Ian's patches to see if they resolve the issue you originally raised in this thread? Thanks, Jim