From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 1/2] pvh: clearly specify used parameters in vcpu_guest_context
Date: Wed, 20 Nov 2013 10:37:12 +0100 [thread overview]
Message-ID: <528C82C8.3080103@citrix.com> (raw)
In-Reply-To: <528C8ECA0200007800104EA4@nat28.tlf.novell.com>
On 20/11/13 10:28, Jan Beulich wrote:
>>>> On 20.11.13 at 10:18, Roger Pau Monné<roger.pau@citrix.com> wrote:
>> On 19/11/13 17:53, Jan Beulich wrote:
>>>>>> On 19.11.13 at 17:42, Roger Pau Monné<roger.pau@citrix.com> wrote:
>>>> Trying to make all those fields functional on PVH (or HVM) is quite
>>>> useless IMHO, it's going to add more code that I doubt anyone is going
>>>> to use when you can instead use the bare metal functions to set all
>>>> those things (and from an OS point of view it's also more comfortable
>>>> because you need less Xen specific stuff).
>>>
>>> That last part I certainly agree to, but that would apply to CR0
>>> and CR4 just as much.
>>
>> I've removed the usage of anything that's not strictly necessary in
>> order to do AP bringup, so I've removed the setting of debugregs:
>
> You can't - this code is also used for HVM guests.
Yes, my fault, I erroneously thought this was introduced by 35b1e076,
but it has been there longer than that. Would you agree to a patch
similar to the one posted, but without touching the setting of debugregs?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-11-20 9:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 12:34 [PATCH 1/2] pvh: proposed BSP/AP bringup changes Roger Pau Monne
2013-11-19 12:34 ` [PATCH 1/2] pvh: clearly specify used parameters in vcpu_guest_context Roger Pau Monne
2013-11-19 13:32 ` Jan Beulich
2013-11-19 15:04 ` Roger Pau Monné
2013-11-19 15:34 ` Jan Beulich
2013-11-19 16:42 ` Roger Pau Monné
2013-11-19 16:53 ` Jan Beulich
2013-11-20 9:18 ` Roger Pau Monné
2013-11-20 9:28 ` Jan Beulich
2013-11-20 9:37 ` Roger Pau Monné [this message]
2013-11-20 9:54 ` Jan Beulich
2013-11-20 10:29 ` Roger Pau Monné
2013-11-20 18:19 ` George Dunlap
2013-11-20 18:24 ` Roger Pau Monné
2013-11-20 21:19 ` Mukesh Rathor
2013-11-22 17:38 ` George Dunlap
2013-11-21 13:16 ` Tim Deegan
2013-11-19 12:34 ` [PATCH 2/2] pvh: set only minimal cr0 and cr4 flags in order to use paging Roger Pau Monne
2013-11-19 13:34 ` Jan Beulich
2013-11-25 13:25 ` Jan Beulich
2013-11-25 14:53 ` George Dunlap
2013-11-25 22:39 ` Mukesh Rathor
2013-11-26 0:29 ` Dong, Eddie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C82C8.3080103@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).