From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Haxby <john.haxby@oracle.com>
Subject: Re: xl command autocompletion: domain names
Date: Wed, 20 Nov 2013 14:06:31 +0000
Message-ID: <528CC1E7.1080803@oracle.com>
References: <CA+nUz_J=DV_GMYkNnq89HTYVYs6xZvZGRzwh+PWRzbH9rCBzng@mail.gmail.com>	<21102.35201.728312.130566@mariner.uk.xensource.com>	<CA+nUz_KP8b+39dM9Yxhks83RuOZcoGL8fnDF4QqQbUjxONXGdQ@mail.gmail.com>	<1383231830.25018.100.camel@dagon.hellion.org.uk>	<CA+nUz_LJQ7+A3z1gitZ6iOFKBK+UbpRXcPFOk16oQ=05Umr=5w@mail.gmail.com>	<21113.4284.248761.181909@mariner.uk.xensource.com>	<CA+nUz_K-PrGNtBh1jfo_GOiTRkDe=GVH0TkveP=GmyfGOkZvig@mail.gmail.com>	<1383732230.26213.34.camel@kazak.uk.xensource.com>	<CA+nUz_KCJ5fTtHq=C7DeYWeSrDqXCsSo-tbdxyfWtMB4Ojs1Ow@mail.gmail.com>	<1383736560.26213.69.camel@kazak.uk.xensource.com>	<CA+nUz_LiuNLBvcfwy0fgU=jJDF3Zdn_jarfU3+F2K8iZDxe=Kw@mail.gmail.com>	<21114.30900.637020.288865@mariner.uk.xensource.com>	<527B6527.4010204@oracle.com>
	<21116.65326.325072.491233@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21116.65326.325072.491233@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Matthew Daley <mattjd@gmail.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 08/11/13 15:11, Ian Jackson wrote:
> John Haxby writes ("Re: [Xen-devel] xl command autocompletion: domain names"):
>> > On 06/11/13 17:13, Ian Jackson wrote:
>>> > >  bash_completion_sudo () {
>>> > >     if [ x"`whoami`" = xroot ]; then "$@"
>>> > >     else ${BASH_COMPLETION_SUDO-sudo} "$@"; fi
>>> > >  }
>>> > >  bash_completion_sudo xl list
>> > 
>> > It's amazing how old constructs make it into new shell scripts for all
>> > the wrong reasons.
> ...
>> > For some reason there has been a resurgence in the belief that you need
>> > the x's _and_ the quotes.  You don't.  Ideally you'd eschew the archaic
>> > construct altogether.
> The x's are there in case the string looks like an operator for
> test(1).  Depending on the exact syntax of the expression inside [ ],
> it can be ambiguous.  In this case it's OK (I think) but IMO it's a
> good habit to always include the x whenever passing string data values
> to test(1).
> 

I hadn't thought of that ...

Except that test doesn't seem so easily fooled:

test -f == root && echo oops
if [ -f == root ]; then echo oops; fi
if [ -f /etc/passwd ]; then echo phew; fi

At least that's the case for bash; dash doesn't like it.

Still, that's today's new Linux/Unix thing so I'm happy!

jch