xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@suse.com>
To: Chunyan Liu <cyliu@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] vhd-util create: add -C|nocow option
Date: Fri, 22 Nov 2013 09:09:59 -0700	[thread overview]
Message-ID: <528F81D7.4010902@suse.com> (raw)
In-Reply-To: <CAERYnoZx98TEhYgUfo3vKxUi2pNnaOg=dsk2_km_9hAYDCtZcQ@mail.gmail.com>

Chunyan Liu wrote:
>
>
>
> 2013/11/22 Jim Fehlig <jfehlig@suse.com <mailto:jfehlig@suse.com>>
>
>     Ian Jackson wrote:
>     > Ian Campbell writes ("Re: [Xen-devel] [PATCH] vhd-util create:
>     add -C|nocow option"):
>     >
>     >> On Thu, 2013-11-21 at 15:46 +0800, Chunyan Liu wrote:
>     >>
>     >>> Add '-C' (nocow) option to vhd-util create.
>     >>>
>     >>> Btrfs has terrible performance when hosting VM images, even
>     more when the guest
>     >>> in those VM are also using btrfs as file system. One way to
>     mitigate this bad
>     >>> performance is to turn off COW attributes on VM files (since
>     having copy on
>     >>> write for this kind of data is not useful). According to
>     'chattr' manpage, NOCOW
>     >>> could be set to new or empty file only on btrfs, so add a
>     option here so that
>     >>> users could have a chance to set NOCOW to a vhd image.
>     >>>
>     >> Is there not some btrfs (or generic) utility which could be
>     used to do
>     >> this after image creation rather than trying to build it in to
>     every
>     >> utility which creates an image file?
>     >>
>     >
>     > This may seem like a daft question, but why do we even have a vhd
>     > utility in our tree ?  Is there not some vhd tools package that this
>     > should be in ?
>     >
>
>     Newer qemu-img supports vhd and vhdx right?  Is there even a need for
>     this tool at all anymore?
>
>
> 'qemu-img create' doesn't support creating vhd/vhdx format images.
> Only open/probe supported.

Ah, I didn't know that.  Is it possible to merge vhd-util with
qemu-img?  You could then support nocow with something like 'qemu-img
create -f vhd -o nocow, ...'.

But I tend to agree with Ian that supporting backing store-specific
features should be higher in the stack.  E.g. a libvirt filesystem
storage pool of type btrfs could support such features when creating
volumes from the pool.

Regards,
Jim

  reply	other threads:[~2013-11-22 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  7:46 [PATCH] vhd-util create: add -C|nocow option Chunyan Liu
2013-11-21  9:39 ` Ian Campbell
2013-11-21 14:41   ` Ian Jackson
2013-11-21 14:51     ` Ian Campbell
2013-11-21 14:59       ` Ian Jackson
2013-11-21 15:01         ` Ian Campbell
2013-11-22  0:57     ` Jim Fehlig
2013-11-22  3:42       ` Chunyan Liu
2013-11-22 16:09         ` Jim Fehlig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-11-21  7:48 Chunyan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528F81D7.4010902@suse.com \
    --to=jfehlig@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=cyliu@suse.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).