xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Mukesh Rathor <mukesh.rathor@oracle.com>,
	"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Cc: Keir Fraser <keir.xen@gmail.com>,
	eddie.dong@intel.com, "Nakajima, Jun" <jun.nakajima@intel.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH V1] pvh: change epte_get_entry_emt() for pvh mem types
Date: Mon, 25 Nov 2013 10:26:12 +0000	[thread overview]
Message-ID: <529325C4.2060807@eu.citrix.com> (raw)
In-Reply-To: <20131122142908.4189cb2b@mantra.us.oracle.com>

On 11/22/2013 10:29 PM, Mukesh Rathor wrote:
> For pvh guests, epte_get_entry_emt() is incorrectly returning WB for
> all mem types because of the following check:
>      if ( !v->domain->arch.hvm_domain.params[HVM_PARAM_IDENT_PT] )
> Skip the check for pvh guests.
>
> Also note, MTRR ranges are not maintained for pvh, and a solution is
> being contrived using PAT.
>
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>

Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>

Also, from a release perspective, this should only affect an as-yet 
unsupported feature.

      reply	other threads:[~2013-11-25 10:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 22:29 [PATCH V1] pvh: change epte_get_entry_emt() for pvh mem types Mukesh Rathor
2013-11-25 10:26 ` George Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529325C4.2060807@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=eddie.dong@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir.xen@gmail.com \
    --cc=mukesh.rathor@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).