From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/panic: Fix string inconsistencies in callers of panic() Date: Mon, 25 Nov 2013 10:42:01 +0000 Message-ID: <52932979.1040804@citrix.com> References: <1385373973-30919-1-git-send-email-andrew.cooper3@citrix.com> <1385375070.22002.8.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385375070.22002.8.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Keir Fraser , George Dunlap , Tim Deegan , Xen-devel , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 25/11/13 10:24, Ian Campbell wrote: > On Mon, 2013-11-25 at 10:06 +0000, Andrew Cooper wrote: >> panic() (as well as early_panic() in arm) is inconsistently called with or >> without a trailing newline. This results in cases where the lower line of >> *****s is not on its own line. >> >> Change panic() to always print a newline itself, and update callers not to. >> >> In addition, panic() was occasionally called with a leading newline, and >> occaionally with trailing punctuation which seems rather redundant given the >> surrounding context. Fix up these sitiuations as well. >> >> Signed-off-by: Andrew Cooper >> CC: Keir Fraser >> CC: Jan Beulich >> CC: Ian Campbell >> CC: Stefano Stabellini >> CC: Tim Deegan >> CC: George Dunlap > I'm not entirely sure I agree with nuking the trailing full stop from > all of the sentences, especially those which are a complete sentence. > > But unless others feel the same I'm not inclined to argue: > Acked-by: Ian Campbell > > > This was at the request of Keir, based on my previous patch from ages ago which fixed up the callers without a newline at the end. ~Andrew