From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v3 09/14] xen: sched: DOMCTL_*vcpuaffinity
 works with hard and soft affinity
Date: Mon, 25 Nov 2013 10:58:36 +0000
Message-ID: <52932D5C.20901@eu.citrix.com>
References: <20131118175544.31002.79574.stgit@Solace>
	<20131118181756.31002.15256.stgit@Solace>
	<528BA24A0200007800104A52@nat28.tlf.novell.com>
	<1385146552.21426.73.camel@Solace>
	<5293274E02000078001066C6@nat28.tlf.novell.com>
	<1385373296.15201.15.camel@Solace>
	<52932DCB020000780010673E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1VktsG-0004s8-Ol
	for xen-devel@lists.xenproject.org; Mon, 25 Nov 2013 10:58:40 +0000
In-Reply-To: <52932DCB020000780010673E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Dario Faggioli <dario.faggioli@citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Justin Weaver <jtweaver@hawaii.edu>, IanCampbell <Ian.Campbell@citrix.com>, Li Yechen <lccycc123@gmail.com>, AndrewCooper <Andrew.Cooper3@citrix.com>, JuergenGross <juergen.gross@ts.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, MattWilson <msw@amazon.com>, xen-devel <xen-devel@lists.xenproject.org>, KeirFraser <keir@xen.org>, Elena Ufimtseva <ufimtseva@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On 11/25/2013 10:00 AM, Jan Beulich wrote:
>>>> On 25.11.13 at 10:54, Dario Faggioli <dario.faggioli@citrix.com> wrote:
>> On lun, 2013-11-25 at 09:32 +0000, Jan Beulich wrote:
>>>>>> On 22.11.13 at 19:55, Dario Faggioli <dario.faggioli@citrix.com> wrote:
>>>> Therefore, I kept this interface as it was here, also considering that:
>>>>   - it's pretty late to re-re-redesign;
>>>>   - neither this nor the xc one are stable interfaces, so we can come
>>>>     back and revisit this later, if we want to.
>>>>
>>>> Do you think this could be acceptable?
>>> I wouldn't veto it, but I also dislike reduced flexibility when more
>>> flexibility is obviously achievable without much effort.
>>>
>> Ok, understood. Ok, I'm up for changing this then. So, let m ask a few
>> questions, just to make sure ot get it right this time! ;-P
>>
>> You are saying the interface should look as follows:
>>
>>   int xc_vcpu_setaffinity(xc_interface *xch,
>>                           uint32_t domid,
>>                           int vcpu,
>>                           xc_cpumap_t cpumap_soft,
>>                           xc_cpumap_t cpumap_hard,
>>                           uint32_t flags);
>>
>> Where both cpumap_soft and cpumap_hard are IN/OUT parameters and, as far
>> as OUT is concerned:
>>   - cpumap_hard will contain hard-affinity&online
>>   - cpumap_soft will contain what?
>>    (a) soft-affinity?
>>    (b) soft-affinity&online
>>    (c) soft-affinity&hard-affinity&online?
> (c) seems the best fit - after all it should represent what the
> hypervisor will effectively use.

+1