From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [Patch v3 0/2] Remove figlet from the source tree Date: Mon, 25 Nov 2013 14:41:23 +0000 Message-ID: <52936193.4080602@eu.citrix.com> References: <1385377211-20637-1-git-send-email-andrew.cooper3@citrix.com> <529340AD.9040904@eu.citrix.com> <21139.24779.602347.49706@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21139.24779.602347.49706@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Andrew Cooper , Keir Fraser , Ian Campbell , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org On 11/25/2013 02:38 PM, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [Patch v3 0/2] Remove figlet from the source tree"): >> On 11/25/2013 11:00 AM, Andrew Cooper wrote: >>> George: >>> This is purely a build change, so I request that it be included for 4.4 >> It's not purely a build change -- figlet is not installed by default on >> a number of distros (Ubuntu didn't have it); and on those systems, this >> will silently change remove the figlet-like lettering from boot. > I agree with these criticisms of Andrew's claims for the patch. > > But I think the inclusion of a fork of figlet in our tree is totally > crazy (and hence a bug). I wouldn't want to introduce this patch > without a release ack but I think the release ack should be granted. If you read to the end, you'll see that it was. :-) -George