From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 1/8] x86: detect and initialize Cache QoS
 Monitoring feature
Date: Mon, 25 Nov 2013 15:40:54 +0000
Message-ID: <52936F86.6000808@citrix.com>
References: <1385018444-104477-1-git-send-email-dongxiao.xu@intel.com>
	<1385018444-104477-2-git-send-email-dongxiao.xu@intel.com>
	<528DF924.4030702@citrix.com>
	<40776A41FC278F40B59438AD47D147A9118BB2A5@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <40776A41FC278F40B59438AD47D147A9118BB2A5@SHSMSX104.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 25/11/13 03:06, Xu, Dongxiao wrote:
>
>>> +    domid_t  domain_id;
>> You will need to include one of the types headers.
> Sorry maybe I didn't quite understand your point here... But, domid_t's definition header file will be included in the arch/x86/pqos.c file before pqos.h is included.

Each header file should include its own dependencies, so a source file
doesn't have to include header files in a specific order to avoid a
compilation error.

~Andrew